Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Javadoc in SettlementController #662

Open
georgeroman opened this issue Jun 14, 2020 · 0 comments
Open

Wrong Javadoc in SettlementController #662

georgeroman opened this issue Jun 14, 2020 · 0 comments
Labels
v1.0 Features to be fixed for a 1.0 release

Comments

@georgeroman
Copy link

The Javadoc for the return value of processOutgoingMessageFromLocalSettlementEngine from SettlementController seems to be wrong:

https://github.com/interledger4j/ilpv4-connector/blob/master/connector-server/src/main/java/org/interledger/connector/server/spring/controllers/settlement/SettlementController.java#L133-L136

That function returns a byte array, not a SettlementQuantity. It was probably copied over from creditIncomingSettlement.
@sappenin sappenin added the v1.0 Features to be fixed for a 1.0 release label Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v1.0 Features to be fixed for a 1.0 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sappenin @georgeroman