Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java connector passes null as the settlement account id on the setupAccount action #672

Open
georgeroman opened this issue Oct 1, 2020 · 0 comments
Labels
v1.0 Features to be fixed for a 1.0 release

Comments

@georgeroman
Copy link

While integrating the Hyperledger Iroha settlement engine with the Java connector, I've noticed that the Java connector passes null as the settlement account identifier when setting up an account with the settlement engine (here is the spec for this action). This is not compliant with the specification and it makes certain settlement engines (ilp-iroha-settlement, ethereum-engine) unusable (these settlement engines perform the step of exchanging ledger identifiers (via the connector's messaging endpoint) in the setup account action but since the connector passes null as the settlement account identifier, the messaging endpoint is not available during this action and the exchange of ledger identifiers fails).

@sappenin sappenin added the v1.0 Features to be fixed for a 1.0 release label Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.0 Features to be fixed for a 1.0 release
Projects
None yet
Development

No branches or pull requests

2 participants