Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #18

Open
dino-rodriguez opened this issue Sep 21, 2018 · 2 comments
Open

Add unit tests #18

dino-rodriguez opened this issue Sep 21, 2018 · 2 comments
Assignees

Comments

@dino-rodriguez
Copy link
Member

dino-rodriguez commented Sep 21, 2018

What happened to the unit tests? I noticed the branch is gone.

A lot of those tests were testing balance/account/store logic as well as packet construction very thoroughly. If they are gone, it is very possible that somebody could edit the plugin and cause a minor breaking change (like balance logic not being calculated properly or persisted to the store) and the integration tests would still pass. I feel this could be pretty dangerous considering the plugin is in beta and will have updates.

@kincaidoneil
Copy link
Member

The branch had been merged in, so they're all in the commit history for ko-refactor. I do still intend to adapt those unit tests for the updated plugin, but probably not before release.

@dino-rodriguez
Copy link
Member Author

Ok great, that makes sense.

@kincaidoneil kincaidoneil changed the title Unit Test Integration Add unit tests Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants