Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Estimate gas for ERC-20 approve, then add open/deposit hardcoded gas limit #41

Open
kincaidoneil opened this issue Jun 24, 2019 · 0 comments
Open

Estimate gas for ERC-20 approve, then add open/deposit hardcoded gas limit #41

kincaidoneil opened this issue Jun 24, 2019 · 0 comments

Comments

@kincaidoneil
Copy link
Member

As opposed to having a hardcoded gas limit for the two combined operations. (Machinomy gas usage for those operations is probably pretty constant, but ERC-20 implementations could in theory use more or less gas.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kincaidoneil