-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor API for latest suite of protocols #130
Comments
I like where you're going with this, but I think the methods that use relative amounts on top of the socket using absolute amounts can make for some strange edge case behavior. Some of the method names sound like they're referring to absolute amounts but your description of the behavior makes it sound like they are making relative changes.
I've deprioritized the project of implementing proper TCP on top of ILP. Do you think we should work on that (or work on it in the near future)? |
based on @justmoon's proposal in interledgerjs/ilp#130 resolves #22
// Connect to a PayStream, defaults to using moneyd
const socket = await ilp.createConnection([ilp address], [shared secret]) Maybe we want to rename both 'socket' and 'connection' to 'stream'? // Connect to a PayStream, defaults to using moneyd
const stream = await ilp.createStream([ilp address], [shared secret]) |
or |
Or one connection, over which multiple streams travel. |
based on @justmoon's proposal in interledgerjs/ilp#130 resolves #22
The
ilp
module should be updated for the latest suite of protocols. It should expose a reasonable API for ILP and PSK/Paystream.Here is a sketch of what the new API might look like:
Basic Usage: PayStream
Basic Usage: Raw packet
Advanced Usage: Using a custom plugin
The text was updated successfully, but these errors were encountered: