Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check workspace packages specify workspace versions #416

Open
sublimator opened this issue Feb 20, 2023 · 2 comments
Open

Check workspace packages specify workspace versions #416

sublimator opened this issue Feb 20, 2023 · 2 comments

Comments

@sublimator
Copy link
Member

Until recently (~Feb 15th ish, 2023) some of these packages were specifying non workspace versions of packages
e.g. stream was using an npm published version of ilp-logger, rather than the monorepo version

This should be checked on CI as part of the generated code diff check

@sublimator
Copy link
Member Author

sublimator commented Feb 20, 2023

Using workspace:* would actually probably cause issues when publishing
So it's maybe best that it should just set them to the version specified in the workspace

@sublimator sublimator changed the title Use workspace:* specification for packages Check workspace packages specify workspace versions Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant