Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full path to module is included in moneyd configuration #9

Open
sharafian opened this issue Jul 17, 2018 · 0 comments
Open

Full path to module is included in moneyd configuration #9

sharafian opened this issue Jul 17, 2018 · 0 comments

Comments

@sharafian
Copy link

https://github.com/interledgerjs/moneyd-uplink-xrp/blob/master/index.js#L82

We're generating the connector configuration and writing it to moneyd.json, including a path to where the ilp-plugin-xrp-asym-client module can be found. This doesn't play nicely with nvm, which includes the node version in its global node module paths. If you move a moneyd.json from one machine to another, where each machine has a different node version installed, it will cease to work.

We could fix this error by just including the parent, the name, and the secret in the moneyd.json file. Then, every time that moneyd starts, we can generate the actual connector configuration from those fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant