Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts conflict in text inputs #284

Open
oskarrough opened this issue Dec 5, 2018 · 3 comments
Open

Keyboard shortcuts conflict in text inputs #284

oskarrough opened this issue Dec 5, 2018 · 3 comments
Labels

Comments

@oskarrough
Copy link
Member

It's not yet working as it should. player keyboard shortcuts are triggering inside (some) inputs.

#282 (comment)
#269

@oskarrough oskarrough added the bug label Dec 5, 2018
@oskarrough
Copy link
Member Author

Fixed in #285

@oskarrough
Copy link
Member Author

This is still a problem in #298

@oskarrough oskarrough reopened this Jan 10, 2019
@oskarrough
Copy link
Member Author

oskarrough commented Jan 14, 2019

It happens when we use the normal <input>. When we use Ember's {{input}}, the keyboard events don't trigger more than they should.

So… to close this issue we have to make sure that the shortcuts defined in https://github.com/internet4000/radio4000/blob/master/app/mixins/keyboard-shortcuts-global.js DO NOT trigger inside either <input> or {{input}}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant