Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Discogs linking loading UX.I #295

Open
4www opened this issue Jan 9, 2019 · 1 comment
Open

Improve Discogs linking loading UX.I #295

4www opened this issue Jan 9, 2019 · 1 comment

Comments

@4www
Copy link
Contributor

4www commented Jan 9, 2019

When you paste in a Discogs release URL on a track, the UI should display and indicator of what is happening.

In this case, pasting the Discogs URL is querying the Discogs database for the release.
That process takes a bit of time, such as 1 second. During this time the user has no visual/sensorial information about something being done, like nothing is happening.

Let's maybe just display a loading message in the place of the where the tags will appear when the request to Discogs' database succeeds.

deepinscreenshot_select-area_20190109130402
Example implementation

Maybe a good place for starting is this component: https://github.com/internet4000/radio4000/blob/master/app/components/track-form/component.js#L51 and its template in the same folder.

@oskarrough
Copy link
Member

Continuing on this, consider doing it like we do for the youtube title with automaticSetTitle() (observer) and fetchTitle() (ember concurrency task) in the same file.

Then you get loading state "for free".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants