Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New OG tags #322

Open
4www opened this issue Feb 5, 2019 · 5 comments
Open

New OG tags #322

4www opened this issue Feb 5, 2019 · 5 comments

Comments

@4www
Copy link
Contributor

4www commented Feb 5, 2019

so when a user share a track url:

  • the media is the youtube video
  • the description is the track's title + body

So then it is just a wrapper around the media (here youtube), with your description.

And when the media is shared, it can be listened directly, not in the context of the radio. Just that track that you're sharing right now. If the person likes the media, excerpt of the radio, they will click the radio4000 track link that was shared, and tune in.

In any case, nobody listens to playlists, or radios, in feeds that pull in content from og tags (twitter, facebook, chat...).

@oskarrough
Copy link
Member

Sounds good. Only challenge I see is how we can get the YouTube embed/preview when we share the track URL?

Also, what happened to our own oembed endpoint?

@4www
Copy link
Contributor Author

4www commented Feb 8, 2019

maybe we can use that, https://www.npmjs.com/package/ember-cli-meta-tags
and build the og tag from the track info

we're using https://github.com/adopted-ember-addons/ember-page-title
seems they can work together

Edit: not sure it is a priority though, just nice to have, as I think it makes sense when you share a track.

@oskarrough
Copy link
Member

oskarrough commented Feb 9, 2019

it's not immediately clear but ember-cli-head is actually a dependency of ember-page-title, so we already have it - and can use it :]

Example:

@oskarrough
Copy link
Member

Also, these meta tags enable the r4 player embed on twitter https://zesty-cold.glitch.me/3.html

@4www
Copy link
Contributor Author

4www commented Feb 9, 2019

Perfect!
With this we can try to make:

  • channel route, embed channel r4-player
  • track route, YouTube track embed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants