Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading a selection is not cleared by clicking on a track in channel.tracks list #414

Open
4www opened this issue Oct 28, 2019 · 1 comment
Labels

Comments

@4www
Copy link
Contributor

4www commented Oct 28, 2019

To reproduce:

  1. go to a channel's /tracks page.
  2. search tracks for any selection giving results
  3. load the search result in the player
  4. click any track from the all tracks list in this radio (not the list in the player, not a track which is in the player's track list)

Expected result: clicking a track (in a channel's /tracks list) not part of the player's track list, should load all tracks, and play the one that was clicked

Actual result: the clicked track is loaded, but the player's selection of tracks (from the previous search) is not cleared

Does this make sense?

@oskarrough
Copy link
Member

oskarrough commented Oct 28, 2019

Makes sense. So, when a track is played, we need to check:

if currentSelection && !currentSelection.contains(playedTrack) ==> reset playlist

?

@4www 4www changed the title Loading a selection is not clearer by clicking on a track in channel.tracks list Loading a selection is not cleared by clicking on a track in channel.tracks list Nov 4, 2019
@oskarrough oskarrough added the bug label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants