Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint-plugin-vue and disable the new "vue/no-mutating-props" rule #4231

Closed
2 tasks done
cdrini opened this issue Dec 9, 2020 · 2 comments · Fixed by #4238
Closed
2 tasks done

Update eslint-plugin-vue and disable the new "vue/no-mutating-props" rule #4231

cdrini opened this issue Dec 9, 2020 · 2 comments · Fixed by #4238
Assignees
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Module: JavaScript Issues related to the JavaScript functionality. [managed] Priority: 3 Issues that we can consider at our leisure. [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Dec 9, 2020

@dependabot tried to update "eslint-plugin-vue" to 7.2.0, but a new rule is incompatible with how a large chunk of our code is written. Let's update and disabled the rule.

Summary of Requirements

Context

See vuejs/eslint-plugin-vue#1371 for details on why we're disabling the rule as opposed to changing our code.

@cdrini cdrini added Module: JavaScript Issues related to the JavaScript functionality. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Good First Issue Easy issue. Good for newcomers. [managed] help-wanted Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] labels Dec 9, 2020
@Sabreen-Parveen
Copy link
Collaborator

@cdrini I would like to work on this issue.

@cdrini
Copy link
Collaborator Author

cdrini commented Dec 9, 2020

Go for it, @Sabreen-Parveen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Module: JavaScript Issues related to the JavaScript functionality. [managed] Priority: 3 Issues that we can consider at our leisure. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants