Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My Books "Followers" widget conflicting with List page long titles #9229

Open
Tracked by #9281
RayBB opened this issue May 7, 2024 · 4 comments · May be fixed by #9285
Open
Tracked by #9281

My Books "Followers" widget conflicting with List page long titles #9229

RayBB opened this issue May 7, 2024 · 4 comments · May be fixed by #9285
Assignees
@mekarpeles
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Priority: 2 Important, as time permits. [managed] Regression Theme: My Books Type: Bug Something isn't working. [managed]
Milestone
Sprint 2024-06

Comments

@RayBB
Copy link
Collaborator

RayBB commented May 7, 2024

Problem

Go to a list you can edit and you'll see it.

Evidence / Screenshot

image

Relevant URL(s)

Reproducing the bug

  1. Go to ...
  2. Do ...
  • Expected behavior:
  • Actual behavior:

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Notes from this Issue's Lead

Proposal & constraints

Related files

Stakeholders
@RayBB RayBB added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels May 7, 2024
@mekarpeles mekarpeles added Regression Priority: 2 Important, as time permits. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Theme: My Books and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels May 13, 2024
@mekarpeles mekarpeles self-assigned this May 13, 2024
@mekarpeles mekarpeles added this to the Sprint 2024-05 milestone May 13, 2024
@mekarpeles mekarpeles mentioned this issue May 16, 2024
Open
7 tasks
@mekarpeles
Copy link
Member

mekarpeles commented May 16, 2024 •
edited

This is specifically happening because the title of the List is long / conflicting with the follow and edit components.

I propose the solution of moving the List title outside of the header

<h1 class="details-title">Understanding the Latin American City</h1>

image

We may also want to make .breadcrumb-wrapper flex: 1 so that it consistently takes up the most space and pushes the follow widget and edit button as far to the right as possible.

@RayBB
Copy link
Collaborator Author

RayBB commented May 16, 2024

Moving the list title outside of the header makes a lot of sense to me @mekarpeles

@mekarpeles
Copy link
Member

mekarpeles commented May 16, 2024 •
edited

I think this is the relevant code.

https://github.com/internetarchive/openlibrary/blob/master/openlibrary/templates/account/view.html#L18-L57

And we probably want to change it accordingly...

Screenshot 2024-05-16 at 9 27 46 AM

See this branch:
https://github.com/internetarchive/openlibrary/tree/fix-mybooks-list-title

@mekarpeles
Copy link
Member

We still likely want to set .breadcrumb-wrapper{ flex: 1; }

@mekarpeles mekarpeles changed the title Followers feature messing up edit lists button My Books "Followers" widget conflicting with List page long titles May 16, 2024
@mekarpeles mekarpeles linked a pull request May 16, 2024 that will close this issue
Open
@mekarpeles mekarpeles added Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] and removed Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] labels May 16, 2024
Noronha01 added a commit to Noronha01/openlibrary that referenced this issue May 27, 2024
@Noronha01
Removed list title from header. internetarchive#9229
98cc4d2
Noronha01 pushed a commit to Noronha01/openlibrary that referenced this issue May 27, 2024
Added to top and to bottom buttons to edit list page. internetarchive…
8e96b84 
…#9023

Removed list title from header. internetarchive#9229

To top button not visible when item is on top, same for to bottom. internetarchive#9023

Added test for new edit page. internetarchive#9023

Corrected identation. internetarchive#9023

Co-authored-by: Barbara Silva <ist1102545@tecnico.ulisboa.pt>

Author: Pedro Noronha <ist1102543@tecnico.ulisboa.pt>
Noronha01 pushed a commit to Noronha01/openlibrary that referenced this issue May 27, 2024
Added to top and to bottom buttons to edit list page. internetarchive…
cfbc3f0 
…#9023

Removed list title from header. internetarchive#9229

To top button not visible when item is on top, same for to bottom. internetarchive#9023

Added test for new edit page. internetarchive#9023

Corrected identation. internetarchive#9023

Co-authored-by: Barbara Silva <ist1102545@tecnico.ulisboa.pt>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mekarpeles mekarpeles

Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Priority: 2 Important, as time permits. [managed] Regression Theme: My Books Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
Sprint 2024-06
2 participants
@RayBB @mekarpeles