Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How did changes to service worker caching impact requests per second to the server? #9239

Open
RayBB opened this issue May 8, 2024 · 4 comments
Assignees
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Theme: Performance Issues related to UI or Server performance. [managed] Type: Question This issue doesn't require code. A question needs an answer. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented May 8, 2024

Once #8930 is deployed we want to answer these questions.

Question

How did requests per second change to the following places:

  • Covers
  • StaticBuild files (css/js)

Additional context

Issue resolution criteria

Stakeholders

@cdrini

@RayBB RayBB added Theme: Performance Issues related to UI or Server performance. [managed] State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] Type: Question This issue doesn't require code. A question needs an answer. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] labels May 8, 2024
@RayBB RayBB changed the title How did improving service worker caching impact request to the server? How did changes to service worker caching impact requests per second to the server? May 15, 2024
@RayBB
Copy link
Collaborator Author

RayBB commented Jun 3, 2024

@cdrini when you get a chance can you look into these numbers? Anecdotally it feels much faster (especially on chrome)

@RayBB RayBB removed the State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] label Jun 3, 2024
@cdrini
Copy link
Collaborator

cdrini commented Jun 3, 2024

Running a script to check now 👍 will take a bit of time to finish

for f in $(ls -r access.log-*.gz);
    do echo $f $(zcat $f | grep -E '/static/build/.*\.js' | wc -l) $(zcat $f | grep -E '/static/build/.*\.css' | wc -l) $(zcat $f | wc -l);
done

Once it starts outputting some data, I might tweak this to exclude bot traffic.

@cdrini
Copy link
Collaborator

cdrini commented Jun 3, 2024

No big difference for css/js ; let me try running it again excluding bots https://docs.google.com/spreadsheets/d/1522-NDs12KkFIErPMstiAEIUT7AcslmZl0QxzrRLrdE/edit#gid=0

@cdrini
Copy link
Collaborator

cdrini commented Jun 3, 2024

grep_not_bot() {
    awk -F'"' '{print $6}' | grep -viE '(bot|spider|crawler)\b'
}

for f in $(ls -r access.log-*.gz);
    do echo $f $(zcat $f | grep -E '/static/build/.*\.js' | grep_not_bot | wc -l) $(zcat $f | grep -E '/static/build/.*\.css' | grep_not_bot | wc -l) $(zcat $f | grep_not_bot | wc -l);
done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Theme: Performance Issues related to UI or Server performance. [managed] Type: Question This issue doesn't require code. A question needs an answer. [managed]
Projects
None yet
Development

No branches or pull requests

2 participants