Setting yearly reading goal fails silently when goal is too large

[jimchamp]

Problem

When a patron attempts to set a yearly reading goal that is greater than 2147483647 books, the request fails but no feedback about the failure is given to the patron.

Evidence / Screenshot

Relevant URL(s)

Goals can be set here: https://openlibrary.org/account/books``

Reproducing the bug

1. Go to https://openlibrary.org/account/books
2. Click the "Set 2024 reading goal" affordance
3. Set an overly ambitious goal

• Expected behavior: Your goal is set and the modal containing the reading goal form is closed.
• Actual behavior: Your goal is not set. The modal remains open. You're tempted to click "Submit" again, but it will do nothing if clicked.

Context

• Browser (Chrome, Safari, Firefox, etc): Any
• OS (Windows, Mac, etc): Any
• Logged in (Y/N): Y
• Environment (prod, dev, local): prod

Notes from this Issue's Lead

Proposal & constraints

Setting a max value of 2147483647 on the reading goal input element is a quick and acceptable solution. An ambitious contributor could also update the /reading-goal POST handler to validate the goal immediately, and return an appropriate status code if the goal is out of range.

Related files

Template for reading goal form:
https://github.com/internetarchive/openlibrary/blob/master/openlibrary/templates/check_ins/reading_goal_form.html

POST handler for reading log goal form:

openlibrary/openlibrary/plugins/upstream/checkins.py

Lines 199 to 232 in 708a80a

	def POST(self):
	i = web.input(goal=0, year=None, is_update=None)
	goal = int(i.goal)
	if i.is_update:
	if goal < 0:
	raise web.badrequest(
	message='Reading goal update must be 0 or a positive integer'
	)
	elif not goal or goal < 1:
	raise web.badrequest(message='Reading goal must be a positive integer')
	if i.is_update and not i.year:
	raise web.badrequest(message='Year required to update reading goals')
	user = get_current_user()
	if not user:
	raise web.unauthorized(message='Requires login')
	username = user['key'].split('/')[-1]
	current_year = i.year or datetime.now().year
	if i.is_update:
	if goal == 0:
	# Delete goal if "0" was submitted:
	YearlyReadingGoals.delete_by_username_and_year(username, i.year)
	else:
	# Update goal normally:
	YearlyReadingGoals.update_target(username, i.year, goal)
	else:
	YearlyReadingGoals.create(username, current_year, goal)
	return delegate.RawText(json.dumps({'status': 'ok'}))

Stakeholders

[Spedi]

Hi there @jimchamp!
Can I work on this issue?

[jimchamp]

@Spedi, you are assigned.

[Spedi]

Hi @jimchamp!
I worked on the issue, but I can't test it because once I try to access the Account page on the dev website I get this error:

Should I push the changes anyway? Do you have any suggestions on how I can see if the code works?
The changes I made are 2:

• Added a max="2147483647" attribute to the input class on the HTML file
• Added this piece of code to the Python file: if goal > 2147483647: raise web.badrequest( message='Reading goal cannot exceed 2147483647 books' )