Cleanup use of is_usergroup_member('/usergroup/super-librarians')

[RayBB]

Problem

Refactor all instance of self.is_usergroup_member('/usergroup/super-librarians') to use is_super_librarian()

This will be very similar to https://github.com/internetarchive/openlibrary/pull/9123/files

This is a followup to #9087

Evidence / Screenshot

Reproducing the bug

No response

Context

No response

Notes from this Issue's Lead

Proposal & constraints

Related files

Stakeholders

[SivanC]

@RayBB Hi, happy to make these changes!

[RayBB]

@SivanC you're assigned. Good luck! If you run into things other than "super-librarians" that might need to be refactored please make a note of it and we can probably do it in a separate PR.

[SivanC]

Will do, thanks!

[SivanC]

@RayBB Four things I noticed:

• Based on your screenshot there may be one use I can't find? 22 results across 18 files for you vs. 21 results across 17 files for me
• Vast majority of uses of is_super_librarian() are in conjunction with is_admin(), including a couple that make their own local is_privileged_user() or similar method, maybe that should added?
• There is still a use of is_usergroup_member('/usergroup/librarians') in /templates/type/authors/view.html line 43
• The ia usergroup doesn't have an is_ia() method, but it's only used once so probably intentional