Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coherent update from 'best-fit' to 'best fit' #417

Merged
merged 1 commit into from Mar 31, 2021
Merged

Coherent update from 'best-fit' to 'best fit' #417

merged 1 commit into from Mar 31, 2021

Conversation

valdoryu
Copy link
Contributor

@valdoryu valdoryu commented Mar 31, 2021

Hi, this PR aims to solve a build issue that occurs when you use vue-i18n 9.0.0 with Vite & Vue 3
Here is the error:

vue-tsc --noEmit && vite build
node_modules/@intlify/core-base/dist/core-base.d.ts:526:26 - error TS2430: Interface 'SpecificDateTimeFormatOptions' incorrectly extends interface 'DateTimeFormatOptions'.
  Types of property 'localeMatcher' are incompatible.
    Type '"lookup" | "best-fit" | undefined' is not assignable to type '"best fit" | "lookup" | undefined'.
      Type '"best-fit"' is not assignable to type '"best fit" | "lookup" | undefined'.

526 export declare interface SpecificDateTimeFormatOptions extends Intl.DateTimeFormatOptions {

On vue-i18n, best-fit was renamed to best-fit in 8.X but the change has not been propagated to core-base

Here is the original PR:
kazupon/vue-i18n#1118

@kazupon kazupon added the Type: Improvement Includes backwards-compatible fixes label Mar 31, 2021
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
This PR resolve #390 too.

Thanks!

@kazupon kazupon merged commit 6c218bf into intlify:master Mar 31, 2021
@kazupon
Copy link
Member

kazupon commented Mar 31, 2021

We will be released with v9.1!
Please wait!

@valdoryu
Copy link
Contributor Author

I will, thank you

@kazupon kazupon mentioned this pull request Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Includes backwards-compatible fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants