Skip to content

Allow number and boolean in args of number formatting #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2021
Merged

Allow number and boolean in args of number formatting #545

merged 2 commits into from
Jul 5, 2021
+22 −13

Conversation

yannbriancon
Copy link
Contributor

Allow use of boolean and numbers in args to handle args such as:

  • useGrouping
  • maximumFractionDigits
  • minimumFractionDigits
  • ....

@kazupon kazupon added the Type: Improvement Includes backwards-compatible fixes label Jun 18, 2021
@PeterAlfredLee
Copy link
Member

@yannbriancon Seems there are some lint error. Please run yarn fix and update this PR, so the CI can pass.

@PeterAlfredLee
Copy link
Member

@yannbriancon also there is a file conflict, please rebase.

@yannbriancon yannbriancon force-pushed the fix/number-formatting-typing branch from ab65dc1 to 22a86dc Compare June 18, 2021 10:52
@yannbriancon
Copy link
Contributor Author

@PeterAlfredLee Done ;)

@kazupon kazupon merged commit c530b4e into intlify:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Improvement Includes backwards-compatible fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yannbriancon @PeterAlfredLee @kazupon @ybr3