Skip to content

improve types declaration #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2022
Merged

improve types declaration #897

merged 2 commits into from
Jan 25, 2022

Conversation

littleboarx
Copy link
Contributor

resolve #889

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
Welcome!

ESLint errors have occurred in CI
Could you fix these errors, please?

@kazupon kazupon added the Type: Bug Bug or Bug fixes label Jan 24, 2022
@littleboarx
Copy link
Contributor Author

Ok, I fixed it.

@kazupon
Copy link
Member

kazupon commented Jan 25, 2022

Thanks!
Good first contribution!
I'll be merging now!

@kazupon kazupon merged commit 32b2c9b into intlify:master Jan 25, 2022
@PeterAlfredLee
Copy link
Member

Hi, @littleboarx , I just checked this PR.
I think the type of strictI18n should be Composer<> instead of Vuei18n<>. WDYT?
image

@littleboarx
Copy link
Contributor Author

Hi, @littleboarx, I just checked this PR. I think the type of strictI18n should be Composer<> instead of Vuei18n<>. WDYT? image

I found out that if you use the generic parameter, it will use the default generic value instant of inferring from the function call. and I edit the test case in line 399. The change to this test case needs to be rolled back.

@kazupon
Copy link
Member

kazupon commented Jan 25, 2022

@littleboarx
If you can resolve it, you can send PR as a fix, else you can't it, we need to roll back.

@littleboarx
Copy link
Contributor Author

see this PR:
#903

@littleboarx If you can resolve it, you can send PR as a fix, else you can't it, we need to roll back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[typescript] I18n.global incorrect type when in "composition" mode (should be Composer, is VueI18n)
3 participants