Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Commit not created when creating blob in isolation #866

Open
mAAdhaTTah opened this issue May 17, 2020 · 1 comment · May be fixed by #1079
Open

Commit not created when creating blob in isolation #866

mAAdhaTTah opened this issue May 17, 2020 · 1 comment · May be fixed by #1079
Labels
Milestone

Comments

@mAAdhaTTah
Copy link
Collaborator

It's only created when appending to existing repo at the repo endpoint & command. This is because the listener only listens to repo updates, not blob updates, which makes sense because blobs are updated as part of a repo update. If we added a new commit every time a blob was saved, we'd add too many.

@mAAdhaTTah mAAdhaTTah added the bug label May 17, 2020
@mAAdhaTTah mAAdhaTTah added this to the 2.0.0 milestone May 17, 2020
@mAAdhaTTah
Copy link
Collaborator Author

We should solve this by querying the repo, updating the blob in it, and saving the repo, rather than querying & working on the blob alone.

mAAdhaTTah added a commit that referenced this issue Jan 16, 2021
Update the usage of `$this->em->{persist,create}` to
`$this->{persist,create}` to ensure the action isn't dispatched when
saving relations, so we can hook into the blob save action to persist
the commit.

Fixes #866.
@mAAdhaTTah mAAdhaTTah linked a pull request Jan 16, 2021 that will close this issue
mAAdhaTTah added a commit that referenced this issue Jan 16, 2021
Update the usage of `$this->em->{persist,create}` to
`$this->{persist,create}` to ensure the action isn't dispatched when
saving relations, so we can hook into the blob save action to persist
the commit.

Fixes #866.
mAAdhaTTah added a commit that referenced this issue Jan 16, 2021
Update the usage of `$this->em->{persist,create}` to
`$this->{persist,create}` to ensure the action isn't dispatched when
saving relations, so we can hook into the blob save action to persist
the commit.

Fixes #866.
mAAdhaTTah added a commit that referenced this issue Jan 16, 2021
Update the usage of `$this->em->{persist,create}` to
`$this->{persist,create}` to ensure the action isn't dispatched when
saving relations, so we can hook into the blob save action to persist
the commit.

Fixes #866.
mAAdhaTTah added a commit that referenced this issue Jan 16, 2021
Update the usage of `$this->em->{persist,create}` to
`$this->{persist,create}` to ensure the action isn't dispatched when
saving relations, so we can hook into the blob save action to persist
the commit.

Fixes #866.
mAAdhaTTah added a commit that referenced this issue Jan 16, 2021
Update the usage of `$this->em->{persist,create}` to
`$this->{persist,create}` to ensure the action isn't dispatched when
saving relations, so we can hook into the blob save action to persist
the commit.

Fixes #866.
mAAdhaTTah added a commit that referenced this issue Jan 16, 2021
Update the usage of `$this->em->{persist,create}` to
`$this->{persist,create}` to ensure the action isn't dispatched when
saving relations, so we can hook into the blob save action to persist
the commit.

Fixes #866.
mAAdhaTTah added a commit that referenced this issue Jan 16, 2021
Update the usage of `$this->em->{persist,create}` to
`$this->{persist,create}` to ensure the action isn't dispatched when
saving relations, so we can hook into the blob save action to persist
the commit.

Fixes #866.
mAAdhaTTah added a commit that referenced this issue Jan 16, 2021
Update the usage of `$this->em->{persist,create}` to
`$this->{persist,create}` to ensure the action isn't dispatched when
saving relations, so we can hook into the blob save action to persist
the commit.

Fixes #866.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant