From 1b9daca46e590738c569f21dc9972c4509ed6bde Mon Sep 17 00:00:00 2001 From: Andrew Lisowski Date: Thu, 11 Feb 2021 16:52:47 -0800 Subject: [PATCH] make canary assets tag at the start of history to avoid tag calculation bugs --- plugins/upload-assets/__tests__/upload-assets-ci.test.ts | 1 + plugins/upload-assets/__tests__/upload-assets.test.ts | 3 +++ plugins/upload-assets/src/index.ts | 1 + 3 files changed, 5 insertions(+) diff --git a/plugins/upload-assets/__tests__/upload-assets-ci.test.ts b/plugins/upload-assets/__tests__/upload-assets-ci.test.ts index 9ed9685a5..3d8660dbe 100644 --- a/plugins/upload-assets/__tests__/upload-assets-ci.test.ts +++ b/plugins/upload-assets/__tests__/upload-assets-ci.test.ts @@ -43,6 +43,7 @@ describe("Upload Assets Plugin", () => { prefixRelease: (v) => v, git: { options, + getFirstCommit: () => 'abc', addToPrBody, github: { repos: { uploadReleaseAsset, createRelease }, diff --git a/plugins/upload-assets/__tests__/upload-assets.test.ts b/plugins/upload-assets/__tests__/upload-assets.test.ts index 5e6fbbecb..f51d9c307 100644 --- a/plugins/upload-assets/__tests__/upload-assets.test.ts +++ b/plugins/upload-assets/__tests__/upload-assets.test.ts @@ -115,6 +115,7 @@ describe("Upload Assets Plugin", () => { logger: dummyLog(), prefixRelease: (v) => v, git: { + getFirstCommit: () => 'abc', options, github: { repos: { uploadReleaseAsset, createRelease }, @@ -192,6 +193,7 @@ describe("Upload Assets Plugin", () => { prefixRelease: (v) => v, git: { options, + getFirstCommit: () => 'abc', github: { repos: { uploadReleaseAsset, createRelease }, paginate: jest.fn().mockResolvedValue([]), @@ -226,6 +228,7 @@ describe("Upload Assets Plugin", () => { prefixRelease: (v) => v, git: { options, + getFirstCommit: () => 'abc', github: { repos: { uploadReleaseAsset, createRelease }, paginate: jest.fn().mockResolvedValue([]), diff --git a/plugins/upload-assets/src/index.ts b/plugins/upload-assets/src/index.ts index e332e39ef..4bc0b3d21 100644 --- a/plugins/upload-assets/src/index.ts +++ b/plugins/upload-assets/src/index.ts @@ -262,6 +262,7 @@ export default class UploadAssetsPlugin implements IPlugin { name: "Canary Assets", prerelease: true, body: `This release contains preview assets of Pull Requests.`, + target_commitish: await auto.git?.getFirstCommit() }); return canaryRelease.data;