Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release label required for next? #1830

Closed
AndrewLeedham opened this issue Feb 24, 2021 · 4 comments
Closed

Release label required for next? #1830

AndrewLeedham opened this issue Feb 24, 2021 · 4 comments
Labels
question Further information is requested

Comments

@AndrewLeedham
Copy link
Contributor

This is more of a question, so I didn't use the template.

When using the onlyPublishWithReleaseLabel prereleases used to release on next regardless of the label, that seems to have changed recently. I am wondering if I was relying on a bug and a prerelease label should be required. Was is the intended behaviour here?

@AndrewLeedham AndrewLeedham added the bug Something isn't working label Feb 24, 2021
@hipstersmoothie hipstersmoothie added question Further information is requested and removed bug Something isn't working labels Feb 24, 2021
@hipstersmoothie
Copy link
Collaborator

This was a recent change. With #1737 we started respecting skip-release (and by extension onlyPublishWithReleaseLabel).

You can use the --force flag/config option to ensure that next always published.

@AndrewLeedham
Copy link
Contributor Author

Makes sense. Is it the release label that trigger it then, as aposed to prerelease?

@hipstersmoothie
Copy link
Collaborator

yeah it's the release label. prerelease is just used to mark PR that have been released in a prerelease

@AndrewLeedham
Copy link
Contributor Author

Gotcha. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants