Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to target a specific commit for a github release #1917

Closed
arical opened this issue Mar 29, 2021 · 3 comments 路 Fixed by #1929
Closed

Request to target a specific commit for a github release #1917

arical opened this issue Mar 29, 2021 · 3 comments 路 Fixed by #1929
Labels
enhancement New feature or request released This issue/pull request has been released.

Comments

@arical
Copy link

arical commented Mar 29, 2021

Hello 馃憢,

Have just started using auto and it looks fantastic so far! Thank you for the great project 馃槃.

We're having one issue though. Auto is creating the Github release against HEAD, instead of the commit we're actually deploying.

This works if you're creating a release for every pull request, but that's not always the case for us and potentially others. Sometimes there might be a commit or two that are in master that we're not releasing yet (they're in our stage environment, waiting for the next release). But when the Github release is created, the tag is always against HEAD.

Context
We're using auto v10.22.0 with git-tag
We use auto release --to ${commit_hash} in our build pipeline when we're ready to ship changes to production.

Describe the solution you'd like
Ideally, when calling release if you pass in --to, that would be passed to Githubs createRelease method. This could override the target_commitish to create the release off the specified version.

It could be an additional flag, but it consistent to limit the release tag if you were already limiting the commit range using --to.

Apologies if this has been brought up before, I couldn't find any older issues or discussions on it.

Thoughts?

@arical arical added the enhancement New feature or request label Mar 29, 2021
@hipstersmoothie
Copy link
Collaborator

I'd be fine with adding something like that. The release command expects that the release has already been tagged and pushed to GitHub. GitHub defaults to tagging the HEAD of the repo is a release is created for a tag that doesn't exists. Before adding the flag do you think that you might be able to change your workflow to add the correct tag?

@arical
Copy link
Author

arical commented Mar 29, 2021

Ahh, thank you! That'll be the missing piece of the puzzle. I'll update our workflow to get us moving again, but I still think it would be a tidy addition if release did that automatically.

Unless I've missed a command (quite likely), we'll need to make sure our build pipeline has the correct git permissions, generate a version number, create and push the tag, then call release.

If release passed through the option we'd only have one line to handle all of that 馃槃.

@adierkens
Copy link
Collaborator

馃殌 Issue was released in v10.24.0 馃殌

@adierkens adierkens added the released This issue/pull request has been released. label Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants