Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle plugin does not work with Gradle version +6.8 #2068

Closed
sugarmanz opened this issue Sep 3, 2021 · 2 comments
Closed

Gradle plugin does not work with Gradle version +6.8 #2068

sugarmanz opened this issue Sep 3, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@sugarmanz
Copy link
Collaborator

Describe the bug

The Gradle release plugin is generating the version commits, which causes Auto to fail when it tries to commit. The Gradle Auto plugin is using the -x Gradle CLI flag to prevent certain tasks from running, however, on the newer versions of Auto, they are running anyways.

Expected behavior

The Gradle release plugin should not be generating commits, as Auto will take care of that.

Additional context

Briefly looked into why Gradle behavior changed, but didn't find much except for this maybe-related issue:
gradle/gradle#17989

@sugarmanz
Copy link
Collaborator Author

Given that the Gradle issue has not been tackled yet, this could most likely be solved on this side by changing the way we invoke the Release plugin:
https://github.com/intuit/auto/blob/main/plugins/gradle/src/index.ts#L115

Rather than invoking the top-level release task with exclusions and relying on that to build, the plugin could just explicitly call the tasks required to perform release (i.e. build & updateNewVersion).
https://github.com/intuit/auto/blob/main/plugins/gradle/src/index.ts#L125

@sugarmanz
Copy link
Collaborator Author

sugarmanz commented Dec 10, 2021

Fixed with #2116 & #2118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant