Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: conventional commit plugin will label an unlabeled PR #1758

Merged
merged 5 commits into from Feb 3, 2021

Conversation

hborawski
Copy link
Collaborator

@hborawski hborawski commented Jan 28, 2021

What Changed

Tap the prCheck hook in conventional-commits plugin to add the semver label to the PR based on the commits if no semver label exists

Why

Discussion in slack, seemed like a useful feature for it to be more automatic when using conventional commits

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux-canary.1758.21676.gz
auto-macos-canary.1758.21676.gz
auto-win.exe-canary.1758.21676.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.14.0-canary.1758.21676.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.14.0-canary.1758.21676.0
npm install @auto-canary/auto@10.14.0-canary.1758.21676.0
npm install @auto-canary/core@10.14.0-canary.1758.21676.0
npm install @auto-canary/package-json-utils@10.14.0-canary.1758.21676.0
npm install @auto-canary/all-contributors@10.14.0-canary.1758.21676.0
npm install @auto-canary/brew@10.14.0-canary.1758.21676.0
npm install @auto-canary/chrome@10.14.0-canary.1758.21676.0
npm install @auto-canary/cocoapods@10.14.0-canary.1758.21676.0
npm install @auto-canary/conventional-commits@10.14.0-canary.1758.21676.0
npm install @auto-canary/crates@10.14.0-canary.1758.21676.0
npm install @auto-canary/docker@10.14.0-canary.1758.21676.0
npm install @auto-canary/exec@10.14.0-canary.1758.21676.0
npm install @auto-canary/first-time-contributor@10.14.0-canary.1758.21676.0
npm install @auto-canary/gem@10.14.0-canary.1758.21676.0
npm install @auto-canary/gh-pages@10.14.0-canary.1758.21676.0
npm install @auto-canary/git-tag@10.14.0-canary.1758.21676.0
npm install @auto-canary/gradle@10.14.0-canary.1758.21676.0
npm install @auto-canary/jira@10.14.0-canary.1758.21676.0
npm install @auto-canary/magic-zero@10.14.0-canary.1758.21676.0
npm install @auto-canary/maven@10.14.0-canary.1758.21676.0
npm install @auto-canary/microsoft-teams@10.14.0-canary.1758.21676.0
npm install @auto-canary/npm@10.14.0-canary.1758.21676.0
npm install @auto-canary/omit-commits@10.14.0-canary.1758.21676.0
npm install @auto-canary/omit-release-notes@10.14.0-canary.1758.21676.0
npm install @auto-canary/pr-body-labels@10.14.0-canary.1758.21676.0
npm install @auto-canary/released@10.14.0-canary.1758.21676.0
npm install @auto-canary/s3@10.14.0-canary.1758.21676.0
npm install @auto-canary/slack@10.14.0-canary.1758.21676.0
npm install @auto-canary/twitter@10.14.0-canary.1758.21676.0
npm install @auto-canary/upload-assets@10.14.0-canary.1758.21676.0
npm install @auto-canary/vscode@10.14.0-canary.1758.21676.0
# or 
yarn add @auto-canary/bot-list@10.14.0-canary.1758.21676.0
yarn add @auto-canary/auto@10.14.0-canary.1758.21676.0
yarn add @auto-canary/core@10.14.0-canary.1758.21676.0
yarn add @auto-canary/package-json-utils@10.14.0-canary.1758.21676.0
yarn add @auto-canary/all-contributors@10.14.0-canary.1758.21676.0
yarn add @auto-canary/brew@10.14.0-canary.1758.21676.0
yarn add @auto-canary/chrome@10.14.0-canary.1758.21676.0
yarn add @auto-canary/cocoapods@10.14.0-canary.1758.21676.0
yarn add @auto-canary/conventional-commits@10.14.0-canary.1758.21676.0
yarn add @auto-canary/crates@10.14.0-canary.1758.21676.0
yarn add @auto-canary/docker@10.14.0-canary.1758.21676.0
yarn add @auto-canary/exec@10.14.0-canary.1758.21676.0
yarn add @auto-canary/first-time-contributor@10.14.0-canary.1758.21676.0
yarn add @auto-canary/gem@10.14.0-canary.1758.21676.0
yarn add @auto-canary/gh-pages@10.14.0-canary.1758.21676.0
yarn add @auto-canary/git-tag@10.14.0-canary.1758.21676.0
yarn add @auto-canary/gradle@10.14.0-canary.1758.21676.0
yarn add @auto-canary/jira@10.14.0-canary.1758.21676.0
yarn add @auto-canary/magic-zero@10.14.0-canary.1758.21676.0
yarn add @auto-canary/maven@10.14.0-canary.1758.21676.0
yarn add @auto-canary/microsoft-teams@10.14.0-canary.1758.21676.0
yarn add @auto-canary/npm@10.14.0-canary.1758.21676.0
yarn add @auto-canary/omit-commits@10.14.0-canary.1758.21676.0
yarn add @auto-canary/omit-release-notes@10.14.0-canary.1758.21676.0
yarn add @auto-canary/pr-body-labels@10.14.0-canary.1758.21676.0
yarn add @auto-canary/released@10.14.0-canary.1758.21676.0
yarn add @auto-canary/s3@10.14.0-canary.1758.21676.0
yarn add @auto-canary/slack@10.14.0-canary.1758.21676.0
yarn add @auto-canary/twitter@10.14.0-canary.1758.21676.0
yarn add @auto-canary/upload-assets@10.14.0-canary.1758.21676.0
yarn add @auto-canary/vscode@10.14.0-canary.1758.21676.0

@adierkens adierkens added the minor Increment the minor version when merged label Jan 28, 2021
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #1758 (a9e87c0) into main (7bf3207) will decrease coverage by 0.09%.
The diff coverage is 68.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1758      +/-   ##
==========================================
- Coverage   80.34%   80.24%   -0.10%     
==========================================
  Files          64       64              
  Lines        4939     4966      +27     
  Branches     1130     1138       +8     
==========================================
+ Hits         3968     3985      +17     
- Misses        668      672       +4     
- Partials      303      309       +6     
Impacted Files Coverage Δ
plugins/conventional-commits/src/index.ts 76.14% <64.28%> (-4.58%) ⬇️
packages/core/src/auto.ts 78.07% <100.00%> (+0.02%) ⬆️
packages/core/src/semver.ts 90.76% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf3207...a9e87c0. Read the comment docs.

Copy link
Collaborator

@hipstersmoothie hipstersmoothie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, still needs a little work

@hipstersmoothie hipstersmoothie merged commit a66eb87 into intuit:main Feb 3, 2021
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.14.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants