Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

released plugin: handle PR numbers that dont exist #1772

Merged
merged 2 commits into from Feb 1, 2021

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Feb 1, 2021

What Changed

see title

Why

If you include #123 and it doesn't exist on the repo auto fails with errors.

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux-canary.1772.21738.gz
auto-macos-canary.1772.21738.gz
auto-win.exe-canary.1772.21738.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.13.4-canary.1772.21738.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.13.4-canary.1772.21738.0
npm install @auto-canary/auto@10.13.4-canary.1772.21738.0
npm install @auto-canary/core@10.13.4-canary.1772.21738.0
npm install @auto-canary/package-json-utils@10.13.4-canary.1772.21738.0
npm install @auto-canary/all-contributors@10.13.4-canary.1772.21738.0
npm install @auto-canary/brew@10.13.4-canary.1772.21738.0
npm install @auto-canary/chrome@10.13.4-canary.1772.21738.0
npm install @auto-canary/cocoapods@10.13.4-canary.1772.21738.0
npm install @auto-canary/conventional-commits@10.13.4-canary.1772.21738.0
npm install @auto-canary/crates@10.13.4-canary.1772.21738.0
npm install @auto-canary/docker@10.13.4-canary.1772.21738.0
npm install @auto-canary/exec@10.13.4-canary.1772.21738.0
npm install @auto-canary/first-time-contributor@10.13.4-canary.1772.21738.0
npm install @auto-canary/gem@10.13.4-canary.1772.21738.0
npm install @auto-canary/gh-pages@10.13.4-canary.1772.21738.0
npm install @auto-canary/git-tag@10.13.4-canary.1772.21738.0
npm install @auto-canary/gradle@10.13.4-canary.1772.21738.0
npm install @auto-canary/jira@10.13.4-canary.1772.21738.0
npm install @auto-canary/magic-zero@10.13.4-canary.1772.21738.0
npm install @auto-canary/maven@10.13.4-canary.1772.21738.0
npm install @auto-canary/microsoft-teams@10.13.4-canary.1772.21738.0
npm install @auto-canary/npm@10.13.4-canary.1772.21738.0
npm install @auto-canary/omit-commits@10.13.4-canary.1772.21738.0
npm install @auto-canary/omit-release-notes@10.13.4-canary.1772.21738.0
npm install @auto-canary/pr-body-labels@10.13.4-canary.1772.21738.0
npm install @auto-canary/released@10.13.4-canary.1772.21738.0
npm install @auto-canary/s3@10.13.4-canary.1772.21738.0
npm install @auto-canary/slack@10.13.4-canary.1772.21738.0
npm install @auto-canary/twitter@10.13.4-canary.1772.21738.0
npm install @auto-canary/upload-assets@10.13.4-canary.1772.21738.0
npm install @auto-canary/vscode@10.13.4-canary.1772.21738.0
# or 
yarn add @auto-canary/bot-list@10.13.4-canary.1772.21738.0
yarn add @auto-canary/auto@10.13.4-canary.1772.21738.0
yarn add @auto-canary/core@10.13.4-canary.1772.21738.0
yarn add @auto-canary/package-json-utils@10.13.4-canary.1772.21738.0
yarn add @auto-canary/all-contributors@10.13.4-canary.1772.21738.0
yarn add @auto-canary/brew@10.13.4-canary.1772.21738.0
yarn add @auto-canary/chrome@10.13.4-canary.1772.21738.0
yarn add @auto-canary/cocoapods@10.13.4-canary.1772.21738.0
yarn add @auto-canary/conventional-commits@10.13.4-canary.1772.21738.0
yarn add @auto-canary/crates@10.13.4-canary.1772.21738.0
yarn add @auto-canary/docker@10.13.4-canary.1772.21738.0
yarn add @auto-canary/exec@10.13.4-canary.1772.21738.0
yarn add @auto-canary/first-time-contributor@10.13.4-canary.1772.21738.0
yarn add @auto-canary/gem@10.13.4-canary.1772.21738.0
yarn add @auto-canary/gh-pages@10.13.4-canary.1772.21738.0
yarn add @auto-canary/git-tag@10.13.4-canary.1772.21738.0
yarn add @auto-canary/gradle@10.13.4-canary.1772.21738.0
yarn add @auto-canary/jira@10.13.4-canary.1772.21738.0
yarn add @auto-canary/magic-zero@10.13.4-canary.1772.21738.0
yarn add @auto-canary/maven@10.13.4-canary.1772.21738.0
yarn add @auto-canary/microsoft-teams@10.13.4-canary.1772.21738.0
yarn add @auto-canary/npm@10.13.4-canary.1772.21738.0
yarn add @auto-canary/omit-commits@10.13.4-canary.1772.21738.0
yarn add @auto-canary/omit-release-notes@10.13.4-canary.1772.21738.0
yarn add @auto-canary/pr-body-labels@10.13.4-canary.1772.21738.0
yarn add @auto-canary/released@10.13.4-canary.1772.21738.0
yarn add @auto-canary/s3@10.13.4-canary.1772.21738.0
yarn add @auto-canary/slack@10.13.4-canary.1772.21738.0
yarn add @auto-canary/twitter@10.13.4-canary.1772.21738.0
yarn add @auto-canary/upload-assets@10.13.4-canary.1772.21738.0
yarn add @auto-canary/vscode@10.13.4-canary.1772.21738.0

@adierkens adierkens added the patch Increment the patch version when merged label Feb 1, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #1772 (5a4eceb) into main (1bcc639) will increase coverage by 0.00%.
The diff coverage is 73.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1772   +/-   ##
=======================================
  Coverage   80.34%   80.34%           
=======================================
  Files          64       64           
  Lines        4939     4941    +2     
  Branches     1077     1130   +53     
=======================================
+ Hits         3968     3970    +2     
  Misses        668      668           
  Partials      303      303           
Impacted Files Coverage Δ
plugins/released/src/index.ts 85.71% <73.33%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f7c32...5a4eceb. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 1149c98 into main Feb 1, 2021
@hipstersmoothie hipstersmoothie deleted the released-bug branch February 1, 2021 20:55
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.13.4 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants