Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create "Canary Release Assets" during non-canary builds + Change that releases tag to valid semver #1802

Merged
merged 4 commits into from Feb 11, 2021

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Feb 11, 2021

Release Notes

This release changes the tag used for the "Canary Releases Assets" created by the upload-assets plugin to be 0.0.0-canary.
This new tag is a valid semantic version and can be used with other auto commands.

If you already have a canary release assets releases this change will create another under a different tag.
This mean you'll have an old "Canary Releases Assets" release that never updates, feel free to delete the tag/release or just ignore it if you want the urls to the old assets to still exist.

What Changed

  • When cleaning up the canary asset we were unintentionally creating the canary asset release
  • Change the tag the canary assets use to be a valid semver. If no tags in the project exist it will fall back to the canary tag in some cases, and that tag must be valid semver

Why

closes #1790

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux-canary.1802.22144.gz
auto-macos-canary.1802.22144.gz
auto-win.exe-canary.1802.22144.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.16.3-canary.1802.22144.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.16.3-canary.1802.22144.0
npm install @auto-canary/auto@10.16.3-canary.1802.22144.0
npm install @auto-canary/core@10.16.3-canary.1802.22144.0
npm install @auto-canary/package-json-utils@10.16.3-canary.1802.22144.0
npm install @auto-canary/all-contributors@10.16.3-canary.1802.22144.0
npm install @auto-canary/brew@10.16.3-canary.1802.22144.0
npm install @auto-canary/chrome@10.16.3-canary.1802.22144.0
npm install @auto-canary/cocoapods@10.16.3-canary.1802.22144.0
npm install @auto-canary/conventional-commits@10.16.3-canary.1802.22144.0
npm install @auto-canary/crates@10.16.3-canary.1802.22144.0
npm install @auto-canary/docker@10.16.3-canary.1802.22144.0
npm install @auto-canary/exec@10.16.3-canary.1802.22144.0
npm install @auto-canary/first-time-contributor@10.16.3-canary.1802.22144.0
npm install @auto-canary/gem@10.16.3-canary.1802.22144.0
npm install @auto-canary/gh-pages@10.16.3-canary.1802.22144.0
npm install @auto-canary/git-tag@10.16.3-canary.1802.22144.0
npm install @auto-canary/gradle@10.16.3-canary.1802.22144.0
npm install @auto-canary/jira@10.16.3-canary.1802.22144.0
npm install @auto-canary/magic-zero@10.16.3-canary.1802.22144.0
npm install @auto-canary/maven@10.16.3-canary.1802.22144.0
npm install @auto-canary/microsoft-teams@10.16.3-canary.1802.22144.0
npm install @auto-canary/npm@10.16.3-canary.1802.22144.0
npm install @auto-canary/omit-commits@10.16.3-canary.1802.22144.0
npm install @auto-canary/omit-release-notes@10.16.3-canary.1802.22144.0
npm install @auto-canary/pr-body-labels@10.16.3-canary.1802.22144.0
npm install @auto-canary/released@10.16.3-canary.1802.22144.0
npm install @auto-canary/s3@10.16.3-canary.1802.22144.0
npm install @auto-canary/slack@10.16.3-canary.1802.22144.0
npm install @auto-canary/twitter@10.16.3-canary.1802.22144.0
npm install @auto-canary/upload-assets@10.16.3-canary.1802.22144.0
npm install @auto-canary/vscode@10.16.3-canary.1802.22144.0
# or 
yarn add @auto-canary/bot-list@10.16.3-canary.1802.22144.0
yarn add @auto-canary/auto@10.16.3-canary.1802.22144.0
yarn add @auto-canary/core@10.16.3-canary.1802.22144.0
yarn add @auto-canary/package-json-utils@10.16.3-canary.1802.22144.0
yarn add @auto-canary/all-contributors@10.16.3-canary.1802.22144.0
yarn add @auto-canary/brew@10.16.3-canary.1802.22144.0
yarn add @auto-canary/chrome@10.16.3-canary.1802.22144.0
yarn add @auto-canary/cocoapods@10.16.3-canary.1802.22144.0
yarn add @auto-canary/conventional-commits@10.16.3-canary.1802.22144.0
yarn add @auto-canary/crates@10.16.3-canary.1802.22144.0
yarn add @auto-canary/docker@10.16.3-canary.1802.22144.0
yarn add @auto-canary/exec@10.16.3-canary.1802.22144.0
yarn add @auto-canary/first-time-contributor@10.16.3-canary.1802.22144.0
yarn add @auto-canary/gem@10.16.3-canary.1802.22144.0
yarn add @auto-canary/gh-pages@10.16.3-canary.1802.22144.0
yarn add @auto-canary/git-tag@10.16.3-canary.1802.22144.0
yarn add @auto-canary/gradle@10.16.3-canary.1802.22144.0
yarn add @auto-canary/jira@10.16.3-canary.1802.22144.0
yarn add @auto-canary/magic-zero@10.16.3-canary.1802.22144.0
yarn add @auto-canary/maven@10.16.3-canary.1802.22144.0
yarn add @auto-canary/microsoft-teams@10.16.3-canary.1802.22144.0
yarn add @auto-canary/npm@10.16.3-canary.1802.22144.0
yarn add @auto-canary/omit-commits@10.16.3-canary.1802.22144.0
yarn add @auto-canary/omit-release-notes@10.16.3-canary.1802.22144.0
yarn add @auto-canary/pr-body-labels@10.16.3-canary.1802.22144.0
yarn add @auto-canary/released@10.16.3-canary.1802.22144.0
yarn add @auto-canary/s3@10.16.3-canary.1802.22144.0
yarn add @auto-canary/slack@10.16.3-canary.1802.22144.0
yarn add @auto-canary/twitter@10.16.3-canary.1802.22144.0
yarn add @auto-canary/upload-assets@10.16.3-canary.1802.22144.0
yarn add @auto-canary/vscode@10.16.3-canary.1802.22144.0

@adierkens adierkens added the patch Increment the patch version when merged label Feb 11, 2021
@hipstersmoothie hipstersmoothie changed the title Don't create "Canary Release Assets" during non-canary builds Don't create "Canary Release Assets" during non-canary builds + Change that releases tag to valid semver Feb 11, 2021
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #1802 (9809ccf) into main (9d61a5e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1802      +/-   ##
==========================================
- Coverage   80.20%   80.18%   -0.03%     
==========================================
  Files          64       64              
  Lines        4991     4996       +5     
  Branches     1151     1153       +2     
==========================================
+ Hits         4003     4006       +3     
- Misses        671      672       +1     
- Partials      317      318       +1     
Impacted Files Coverage Δ
plugins/upload-assets/src/index.ts 89.18% <100.00%> (-1.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d61a5e...9809ccf. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 8367182 into main Feb 11, 2021
@hipstersmoothie hipstersmoothie deleted the upload-assets-canary branch February 11, 2021 22:06
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.16.3 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload Assets plugin: do not create Canary tag/prerelease when running in base branch
2 participants