Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make canary assets tag at the start of history to avoid tag calculation bugs #1803

Merged
merged 1 commit into from Feb 12, 2021

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Feb 12, 2021

What Changed

see title

Why

Previously the canary asset tag was created at the tip of baseBranch. With this change we now tag the very first commit in the repo with 0.0.0-canary, this way any commands that find the latest tag in a branch don't accidentally find the canary assets tag.

Todo:

  • Add tests

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux-canary.1803.22158.gz
auto-macos-canary.1803.22158.gz
auto-win.exe-canary.1803.22158.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.16.4-canary.1803.22158.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.16.4-canary.1803.22158.0
npm install @auto-canary/auto@10.16.4-canary.1803.22158.0
npm install @auto-canary/core@10.16.4-canary.1803.22158.0
npm install @auto-canary/package-json-utils@10.16.4-canary.1803.22158.0
npm install @auto-canary/all-contributors@10.16.4-canary.1803.22158.0
npm install @auto-canary/brew@10.16.4-canary.1803.22158.0
npm install @auto-canary/chrome@10.16.4-canary.1803.22158.0
npm install @auto-canary/cocoapods@10.16.4-canary.1803.22158.0
npm install @auto-canary/conventional-commits@10.16.4-canary.1803.22158.0
npm install @auto-canary/crates@10.16.4-canary.1803.22158.0
npm install @auto-canary/docker@10.16.4-canary.1803.22158.0
npm install @auto-canary/exec@10.16.4-canary.1803.22158.0
npm install @auto-canary/first-time-contributor@10.16.4-canary.1803.22158.0
npm install @auto-canary/gem@10.16.4-canary.1803.22158.0
npm install @auto-canary/gh-pages@10.16.4-canary.1803.22158.0
npm install @auto-canary/git-tag@10.16.4-canary.1803.22158.0
npm install @auto-canary/gradle@10.16.4-canary.1803.22158.0
npm install @auto-canary/jira@10.16.4-canary.1803.22158.0
npm install @auto-canary/magic-zero@10.16.4-canary.1803.22158.0
npm install @auto-canary/maven@10.16.4-canary.1803.22158.0
npm install @auto-canary/microsoft-teams@10.16.4-canary.1803.22158.0
npm install @auto-canary/npm@10.16.4-canary.1803.22158.0
npm install @auto-canary/omit-commits@10.16.4-canary.1803.22158.0
npm install @auto-canary/omit-release-notes@10.16.4-canary.1803.22158.0
npm install @auto-canary/pr-body-labels@10.16.4-canary.1803.22158.0
npm install @auto-canary/released@10.16.4-canary.1803.22158.0
npm install @auto-canary/s3@10.16.4-canary.1803.22158.0
npm install @auto-canary/slack@10.16.4-canary.1803.22158.0
npm install @auto-canary/twitter@10.16.4-canary.1803.22158.0
npm install @auto-canary/upload-assets@10.16.4-canary.1803.22158.0
npm install @auto-canary/vscode@10.16.4-canary.1803.22158.0
# or 
yarn add @auto-canary/bot-list@10.16.4-canary.1803.22158.0
yarn add @auto-canary/auto@10.16.4-canary.1803.22158.0
yarn add @auto-canary/core@10.16.4-canary.1803.22158.0
yarn add @auto-canary/package-json-utils@10.16.4-canary.1803.22158.0
yarn add @auto-canary/all-contributors@10.16.4-canary.1803.22158.0
yarn add @auto-canary/brew@10.16.4-canary.1803.22158.0
yarn add @auto-canary/chrome@10.16.4-canary.1803.22158.0
yarn add @auto-canary/cocoapods@10.16.4-canary.1803.22158.0
yarn add @auto-canary/conventional-commits@10.16.4-canary.1803.22158.0
yarn add @auto-canary/crates@10.16.4-canary.1803.22158.0
yarn add @auto-canary/docker@10.16.4-canary.1803.22158.0
yarn add @auto-canary/exec@10.16.4-canary.1803.22158.0
yarn add @auto-canary/first-time-contributor@10.16.4-canary.1803.22158.0
yarn add @auto-canary/gem@10.16.4-canary.1803.22158.0
yarn add @auto-canary/gh-pages@10.16.4-canary.1803.22158.0
yarn add @auto-canary/git-tag@10.16.4-canary.1803.22158.0
yarn add @auto-canary/gradle@10.16.4-canary.1803.22158.0
yarn add @auto-canary/jira@10.16.4-canary.1803.22158.0
yarn add @auto-canary/magic-zero@10.16.4-canary.1803.22158.0
yarn add @auto-canary/maven@10.16.4-canary.1803.22158.0
yarn add @auto-canary/microsoft-teams@10.16.4-canary.1803.22158.0
yarn add @auto-canary/npm@10.16.4-canary.1803.22158.0
yarn add @auto-canary/omit-commits@10.16.4-canary.1803.22158.0
yarn add @auto-canary/omit-release-notes@10.16.4-canary.1803.22158.0
yarn add @auto-canary/pr-body-labels@10.16.4-canary.1803.22158.0
yarn add @auto-canary/released@10.16.4-canary.1803.22158.0
yarn add @auto-canary/s3@10.16.4-canary.1803.22158.0
yarn add @auto-canary/slack@10.16.4-canary.1803.22158.0
yarn add @auto-canary/twitter@10.16.4-canary.1803.22158.0
yarn add @auto-canary/upload-assets@10.16.4-canary.1803.22158.0
yarn add @auto-canary/vscode@10.16.4-canary.1803.22158.0

@adierkens adierkens added the patch Increment the patch version when merged label Feb 12, 2021
@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #1803 (1b9daca) into main (9809ccf) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1803      +/-   ##
==========================================
- Coverage   80.18%   80.16%   -0.02%     
==========================================
  Files          64       64              
  Lines        4996     4997       +1     
  Branches     1153     1154       +1     
==========================================
  Hits         4006     4006              
  Misses        672      672              
- Partials      318      319       +1     
Impacted Files Coverage Δ
plugins/upload-assets/src/index.ts 88.39% <0.00%> (-0.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9809ccf...1b9daca. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 0efae8f into main Feb 12, 2021
@hipstersmoothie hipstersmoothie deleted the upload-assets-canary branch February 12, 2021 01:03
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.16.4 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Feb 12, 2021
@ktamilvanan
Copy link

@hipstersmoothie Thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants