New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prefer prerelease tags when determining latest #1812
fix: prefer prerelease tags when determining latest #1812
Conversation
|
||
expect(await gh.getTagNotInBaseBranch("alpha")).toBe("1.4.1-alpha.1"); | ||
|
||
expect(await gh.getTagNotInBaseBranch("beta")).toBe("1.4.1-beta.2"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is 🔥
The cli file is for testing and should be removed from this PR, should probably git ignore it too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Just need to investigate what test is failing
6b87b61
to
61266ae
Compare
61266ae
to
8af14a7
Compare
@hipstersmoothie I anticipate the issues are due to some logic coming from a forked PR? |
Ah got it, just needed to update my fork with latest, should have another push soon |
Codecov Report
@@ Coverage Diff @@
## main #1812 +/- ##
==========================================
+ Coverage 80.16% 80.18% +0.01%
==========================================
Files 64 64
Lines 4997 5001 +4
Branches 1154 1155 +1
==========================================
+ Hits 4006 4010 +4
Misses 672 672
Partials 319 319
Continue to review full report at Codecov.
|
🚀 PR was released in |
What Changed
Have the comparator prefer tags with a prerelease branch name within it to make sure the calculated next version is the latest from that branch.
Why
Semver will consider
1.4.0-beta.0
to have higher precedence to1.4.0-alpha.6
due to how it evaluates the two channels. In this case, we are likely developing againstalpha
only, and thus want to bump it's version to1.4.0-alpha.7
, but the prerelease will determine the next version to be1.4.0-alpha.0
.Todo:
Change Type
Indicate the type of change your pull request is:
documentation
patch
minor
major