Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mock-fs for npm tests #1827

Merged
merged 3 commits into from Feb 23, 2021
Merged

Use mock-fs for npm tests #1827

merged 3 commits into from Feb 23, 2021

Conversation

zephraph
Copy link
Collaborator

@zephraph zephraph commented Feb 23, 2021

What Changed

Instead of individually mocked fs methods the npm plugin tests now use mockFs to do their work. This largely makes the tests more robust as we care less about what fs calls are happening and more about the shape of the filesystem data.

Why

I needed it for the .npmrc refactor since that updates utils which adds/removes fs calls which made a lot of these tests break when they shouldn't have.

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major
  • internal

🐤 Download canary assets:

auto-linux-canary.1827.22516.gz
auto-macos-canary.1827.22516.gz
auto-win.exe-canary.1827.22516.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.16.8-canary.1827.22516.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.16.8-canary.1827.22516.0
npm install @auto-canary/auto@10.16.8-canary.1827.22516.0
npm install @auto-canary/core@10.16.8-canary.1827.22516.0
npm install @auto-canary/package-json-utils@10.16.8-canary.1827.22516.0
npm install @auto-canary/all-contributors@10.16.8-canary.1827.22516.0
npm install @auto-canary/brew@10.16.8-canary.1827.22516.0
npm install @auto-canary/chrome@10.16.8-canary.1827.22516.0
npm install @auto-canary/cocoapods@10.16.8-canary.1827.22516.0
npm install @auto-canary/conventional-commits@10.16.8-canary.1827.22516.0
npm install @auto-canary/crates@10.16.8-canary.1827.22516.0
npm install @auto-canary/docker@10.16.8-canary.1827.22516.0
npm install @auto-canary/exec@10.16.8-canary.1827.22516.0
npm install @auto-canary/first-time-contributor@10.16.8-canary.1827.22516.0
npm install @auto-canary/gem@10.16.8-canary.1827.22516.0
npm install @auto-canary/gh-pages@10.16.8-canary.1827.22516.0
npm install @auto-canary/git-tag@10.16.8-canary.1827.22516.0
npm install @auto-canary/gradle@10.16.8-canary.1827.22516.0
npm install @auto-canary/jira@10.16.8-canary.1827.22516.0
npm install @auto-canary/magic-zero@10.16.8-canary.1827.22516.0
npm install @auto-canary/maven@10.16.8-canary.1827.22516.0
npm install @auto-canary/microsoft-teams@10.16.8-canary.1827.22516.0
npm install @auto-canary/npm@10.16.8-canary.1827.22516.0
npm install @auto-canary/omit-commits@10.16.8-canary.1827.22516.0
npm install @auto-canary/omit-release-notes@10.16.8-canary.1827.22516.0
npm install @auto-canary/pr-body-labels@10.16.8-canary.1827.22516.0
npm install @auto-canary/released@10.16.8-canary.1827.22516.0
npm install @auto-canary/s3@10.16.8-canary.1827.22516.0
npm install @auto-canary/slack@10.16.8-canary.1827.22516.0
npm install @auto-canary/twitter@10.16.8-canary.1827.22516.0
npm install @auto-canary/upload-assets@10.16.8-canary.1827.22516.0
npm install @auto-canary/vscode@10.16.8-canary.1827.22516.0
# or 
yarn add @auto-canary/bot-list@10.16.8-canary.1827.22516.0
yarn add @auto-canary/auto@10.16.8-canary.1827.22516.0
yarn add @auto-canary/core@10.16.8-canary.1827.22516.0
yarn add @auto-canary/package-json-utils@10.16.8-canary.1827.22516.0
yarn add @auto-canary/all-contributors@10.16.8-canary.1827.22516.0
yarn add @auto-canary/brew@10.16.8-canary.1827.22516.0
yarn add @auto-canary/chrome@10.16.8-canary.1827.22516.0
yarn add @auto-canary/cocoapods@10.16.8-canary.1827.22516.0
yarn add @auto-canary/conventional-commits@10.16.8-canary.1827.22516.0
yarn add @auto-canary/crates@10.16.8-canary.1827.22516.0
yarn add @auto-canary/docker@10.16.8-canary.1827.22516.0
yarn add @auto-canary/exec@10.16.8-canary.1827.22516.0
yarn add @auto-canary/first-time-contributor@10.16.8-canary.1827.22516.0
yarn add @auto-canary/gem@10.16.8-canary.1827.22516.0
yarn add @auto-canary/gh-pages@10.16.8-canary.1827.22516.0
yarn add @auto-canary/git-tag@10.16.8-canary.1827.22516.0
yarn add @auto-canary/gradle@10.16.8-canary.1827.22516.0
yarn add @auto-canary/jira@10.16.8-canary.1827.22516.0
yarn add @auto-canary/magic-zero@10.16.8-canary.1827.22516.0
yarn add @auto-canary/maven@10.16.8-canary.1827.22516.0
yarn add @auto-canary/microsoft-teams@10.16.8-canary.1827.22516.0
yarn add @auto-canary/npm@10.16.8-canary.1827.22516.0
yarn add @auto-canary/omit-commits@10.16.8-canary.1827.22516.0
yarn add @auto-canary/omit-release-notes@10.16.8-canary.1827.22516.0
yarn add @auto-canary/pr-body-labels@10.16.8-canary.1827.22516.0
yarn add @auto-canary/released@10.16.8-canary.1827.22516.0
yarn add @auto-canary/s3@10.16.8-canary.1827.22516.0
yarn add @auto-canary/slack@10.16.8-canary.1827.22516.0
yarn add @auto-canary/twitter@10.16.8-canary.1827.22516.0
yarn add @auto-canary/upload-assets@10.16.8-canary.1827.22516.0
yarn add @auto-canary/vscode@10.16.8-canary.1827.22516.0

@adierkens adierkens added the internal Changes only affect the internal API label Feb 23, 2021
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #1827 (5f9b50b) into main (239fa84) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1827      +/-   ##
==========================================
- Coverage   80.18%   80.10%   -0.08%     
==========================================
  Files          64       64              
  Lines        5001     5001              
  Branches     1155     1155              
==========================================
- Hits         4010     4006       -4     
- Misses        672      673       +1     
- Partials      319      322       +3     
Impacted Files Coverage Δ
plugins/npm/src/index.ts 73.30% <0.00%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 239fa84...5f9b50b. Read the comment docs.

Copy link
Collaborator

@hipstersmoothie hipstersmoothie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much better than what was there before, thanks!

@hipstersmoothie hipstersmoothie merged commit e77a47c into main Feb 23, 2021
@hipstersmoothie hipstersmoothie deleted the refactor-npm-tests branch February 23, 2021 06:47
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.16.8 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants