Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Instead of individually mocked fs methods the npm plugin tests now use mockFs to do their work. This largely makes the tests more robust as we care less about what fs calls are happening and more about the shape of the filesystem data.
Why
I needed it for the .npmrc refactor since that updates utils which adds/removes fs calls which made a lot of these tests break when they shouldn't have.
Change Type
Indicate the type of change your pull request is:
documentation
patch
minor
major
internal
🐤 Download canary assets:
auto-linux-canary.1827.22516.gz
auto-macos-canary.1827.22516.gz
auto-win.exe-canary.1827.22516.gz
📦 Published PR as canary version:
under canary scope @auto-canary@10.16.8-canary.1827.22516.0
✨ Test out this PR locally via:
npm install @auto-canary/bot-list@10.16.8-canary.1827.22516.0 npm install @auto-canary/auto@10.16.8-canary.1827.22516.0 npm install @auto-canary/core@10.16.8-canary.1827.22516.0 npm install @auto-canary/package-json-utils@10.16.8-canary.1827.22516.0 npm install @auto-canary/all-contributors@10.16.8-canary.1827.22516.0 npm install @auto-canary/brew@10.16.8-canary.1827.22516.0 npm install @auto-canary/chrome@10.16.8-canary.1827.22516.0 npm install @auto-canary/cocoapods@10.16.8-canary.1827.22516.0 npm install @auto-canary/conventional-commits@10.16.8-canary.1827.22516.0 npm install @auto-canary/crates@10.16.8-canary.1827.22516.0 npm install @auto-canary/docker@10.16.8-canary.1827.22516.0 npm install @auto-canary/exec@10.16.8-canary.1827.22516.0 npm install @auto-canary/first-time-contributor@10.16.8-canary.1827.22516.0 npm install @auto-canary/gem@10.16.8-canary.1827.22516.0 npm install @auto-canary/gh-pages@10.16.8-canary.1827.22516.0 npm install @auto-canary/git-tag@10.16.8-canary.1827.22516.0 npm install @auto-canary/gradle@10.16.8-canary.1827.22516.0 npm install @auto-canary/jira@10.16.8-canary.1827.22516.0 npm install @auto-canary/magic-zero@10.16.8-canary.1827.22516.0 npm install @auto-canary/maven@10.16.8-canary.1827.22516.0 npm install @auto-canary/microsoft-teams@10.16.8-canary.1827.22516.0 npm install @auto-canary/npm@10.16.8-canary.1827.22516.0 npm install @auto-canary/omit-commits@10.16.8-canary.1827.22516.0 npm install @auto-canary/omit-release-notes@10.16.8-canary.1827.22516.0 npm install @auto-canary/pr-body-labels@10.16.8-canary.1827.22516.0 npm install @auto-canary/released@10.16.8-canary.1827.22516.0 npm install @auto-canary/s3@10.16.8-canary.1827.22516.0 npm install @auto-canary/slack@10.16.8-canary.1827.22516.0 npm install @auto-canary/twitter@10.16.8-canary.1827.22516.0 npm install @auto-canary/upload-assets@10.16.8-canary.1827.22516.0 npm install @auto-canary/vscode@10.16.8-canary.1827.22516.0 # or yarn add @auto-canary/bot-list@10.16.8-canary.1827.22516.0 yarn add @auto-canary/auto@10.16.8-canary.1827.22516.0 yarn add @auto-canary/core@10.16.8-canary.1827.22516.0 yarn add @auto-canary/package-json-utils@10.16.8-canary.1827.22516.0 yarn add @auto-canary/all-contributors@10.16.8-canary.1827.22516.0 yarn add @auto-canary/brew@10.16.8-canary.1827.22516.0 yarn add @auto-canary/chrome@10.16.8-canary.1827.22516.0 yarn add @auto-canary/cocoapods@10.16.8-canary.1827.22516.0 yarn add @auto-canary/conventional-commits@10.16.8-canary.1827.22516.0 yarn add @auto-canary/crates@10.16.8-canary.1827.22516.0 yarn add @auto-canary/docker@10.16.8-canary.1827.22516.0 yarn add @auto-canary/exec@10.16.8-canary.1827.22516.0 yarn add @auto-canary/first-time-contributor@10.16.8-canary.1827.22516.0 yarn add @auto-canary/gem@10.16.8-canary.1827.22516.0 yarn add @auto-canary/gh-pages@10.16.8-canary.1827.22516.0 yarn add @auto-canary/git-tag@10.16.8-canary.1827.22516.0 yarn add @auto-canary/gradle@10.16.8-canary.1827.22516.0 yarn add @auto-canary/jira@10.16.8-canary.1827.22516.0 yarn add @auto-canary/magic-zero@10.16.8-canary.1827.22516.0 yarn add @auto-canary/maven@10.16.8-canary.1827.22516.0 yarn add @auto-canary/microsoft-teams@10.16.8-canary.1827.22516.0 yarn add @auto-canary/npm@10.16.8-canary.1827.22516.0 yarn add @auto-canary/omit-commits@10.16.8-canary.1827.22516.0 yarn add @auto-canary/omit-release-notes@10.16.8-canary.1827.22516.0 yarn add @auto-canary/pr-body-labels@10.16.8-canary.1827.22516.0 yarn add @auto-canary/released@10.16.8-canary.1827.22516.0 yarn add @auto-canary/s3@10.16.8-canary.1827.22516.0 yarn add @auto-canary/slack@10.16.8-canary.1827.22516.0 yarn add @auto-canary/twitter@10.16.8-canary.1827.22516.0 yarn add @auto-canary/upload-assets@10.16.8-canary.1827.22516.0 yarn add @auto-canary/vscode@10.16.8-canary.1827.22516.0