Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve GitHub actions docs + remove unnecessary warning #1828

Merged
merged 2 commits into from Feb 24, 2021
Merged

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Feb 23, 2021

What Changed

  • add more docs
  • remove that NPM_TOKEN since it doesn't matter
  • Add context around the admin token for branch protection

Why

closes #1821

Todo:

  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux-canary.1828.22555.gz
auto-macos-canary.1828.22555.gz
auto-win.exe-canary.1828.22555.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.16.8-canary.1828.22528.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.16.8-canary.1828.22528.0
npm install @auto-canary/auto@10.16.8-canary.1828.22528.0
npm install @auto-canary/core@10.16.8-canary.1828.22528.0
npm install @auto-canary/package-json-utils@10.16.8-canary.1828.22528.0
npm install @auto-canary/all-contributors@10.16.8-canary.1828.22528.0
npm install @auto-canary/brew@10.16.8-canary.1828.22528.0
npm install @auto-canary/chrome@10.16.8-canary.1828.22528.0
npm install @auto-canary/cocoapods@10.16.8-canary.1828.22528.0
npm install @auto-canary/conventional-commits@10.16.8-canary.1828.22528.0
npm install @auto-canary/crates@10.16.8-canary.1828.22528.0
npm install @auto-canary/docker@10.16.8-canary.1828.22528.0
npm install @auto-canary/exec@10.16.8-canary.1828.22528.0
npm install @auto-canary/first-time-contributor@10.16.8-canary.1828.22528.0
npm install @auto-canary/gem@10.16.8-canary.1828.22528.0
npm install @auto-canary/gh-pages@10.16.8-canary.1828.22528.0
npm install @auto-canary/git-tag@10.16.8-canary.1828.22528.0
npm install @auto-canary/gradle@10.16.8-canary.1828.22528.0
npm install @auto-canary/jira@10.16.8-canary.1828.22528.0
npm install @auto-canary/magic-zero@10.16.8-canary.1828.22528.0
npm install @auto-canary/maven@10.16.8-canary.1828.22528.0
npm install @auto-canary/microsoft-teams@10.16.8-canary.1828.22528.0
npm install @auto-canary/npm@10.16.8-canary.1828.22528.0
npm install @auto-canary/omit-commits@10.16.8-canary.1828.22528.0
npm install @auto-canary/omit-release-notes@10.16.8-canary.1828.22528.0
npm install @auto-canary/pr-body-labels@10.16.8-canary.1828.22528.0
npm install @auto-canary/released@10.16.8-canary.1828.22528.0
npm install @auto-canary/s3@10.16.8-canary.1828.22528.0
npm install @auto-canary/slack@10.16.8-canary.1828.22528.0
npm install @auto-canary/twitter@10.16.8-canary.1828.22528.0
npm install @auto-canary/upload-assets@10.16.8-canary.1828.22528.0
npm install @auto-canary/vscode@10.16.8-canary.1828.22528.0
# or 
yarn add @auto-canary/bot-list@10.16.8-canary.1828.22528.0
yarn add @auto-canary/auto@10.16.8-canary.1828.22528.0
yarn add @auto-canary/core@10.16.8-canary.1828.22528.0
yarn add @auto-canary/package-json-utils@10.16.8-canary.1828.22528.0
yarn add @auto-canary/all-contributors@10.16.8-canary.1828.22528.0
yarn add @auto-canary/brew@10.16.8-canary.1828.22528.0
yarn add @auto-canary/chrome@10.16.8-canary.1828.22528.0
yarn add @auto-canary/cocoapods@10.16.8-canary.1828.22528.0
yarn add @auto-canary/conventional-commits@10.16.8-canary.1828.22528.0
yarn add @auto-canary/crates@10.16.8-canary.1828.22528.0
yarn add @auto-canary/docker@10.16.8-canary.1828.22528.0
yarn add @auto-canary/exec@10.16.8-canary.1828.22528.0
yarn add @auto-canary/first-time-contributor@10.16.8-canary.1828.22528.0
yarn add @auto-canary/gem@10.16.8-canary.1828.22528.0
yarn add @auto-canary/gh-pages@10.16.8-canary.1828.22528.0
yarn add @auto-canary/git-tag@10.16.8-canary.1828.22528.0
yarn add @auto-canary/gradle@10.16.8-canary.1828.22528.0
yarn add @auto-canary/jira@10.16.8-canary.1828.22528.0
yarn add @auto-canary/magic-zero@10.16.8-canary.1828.22528.0
yarn add @auto-canary/maven@10.16.8-canary.1828.22528.0
yarn add @auto-canary/microsoft-teams@10.16.8-canary.1828.22528.0
yarn add @auto-canary/npm@10.16.8-canary.1828.22528.0
yarn add @auto-canary/omit-commits@10.16.8-canary.1828.22528.0
yarn add @auto-canary/omit-release-notes@10.16.8-canary.1828.22528.0
yarn add @auto-canary/pr-body-labels@10.16.8-canary.1828.22528.0
yarn add @auto-canary/released@10.16.8-canary.1828.22528.0
yarn add @auto-canary/s3@10.16.8-canary.1828.22528.0
yarn add @auto-canary/slack@10.16.8-canary.1828.22528.0
yarn add @auto-canary/twitter@10.16.8-canary.1828.22528.0
yarn add @auto-canary/upload-assets@10.16.8-canary.1828.22528.0
yarn add @auto-canary/vscode@10.16.8-canary.1828.22528.0

@adierkens adierkens added the patch Increment the patch version when merged label Feb 23, 2021
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #1828 (9c1d531) into main (e77a47c) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1828   +/-   ##
=======================================
  Coverage   80.10%   80.10%           
=======================================
  Files          64       64           
  Lines        5001     5002    +1     
  Branches     1155     1156    +1     
=======================================
+ Hits         4006     4007    +1     
  Misses        673      673           
  Partials      322      322           
Impacted Files Coverage Δ
plugins/npm/src/index.ts 73.35% <50.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77a47c...3da6de5. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 218274e into main Feb 24, 2021
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.16.8 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Action failing to find NPM_TOKEN
3 participants