Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix validating slack config with mixed options #1844

Merged
merged 1 commit into from Mar 2, 2021

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Mar 2, 2021

Why

The function could validation just auth and channels but broken when atTarget was also included

Todo:

  • Add tests

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux-canary.1844.22649.gz
auto-macos-canary.1844.22649.gz
auto-win.exe-canary.1844.22649.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.17.1-canary.1844.22649.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.17.1-canary.1844.22649.0
npm install @auto-canary/auto@10.17.1-canary.1844.22649.0
npm install @auto-canary/core@10.17.1-canary.1844.22649.0
npm install @auto-canary/package-json-utils@10.17.1-canary.1844.22649.0
npm install @auto-canary/all-contributors@10.17.1-canary.1844.22649.0
npm install @auto-canary/brew@10.17.1-canary.1844.22649.0
npm install @auto-canary/chrome@10.17.1-canary.1844.22649.0
npm install @auto-canary/cocoapods@10.17.1-canary.1844.22649.0
npm install @auto-canary/conventional-commits@10.17.1-canary.1844.22649.0
npm install @auto-canary/crates@10.17.1-canary.1844.22649.0
npm install @auto-canary/docker@10.17.1-canary.1844.22649.0
npm install @auto-canary/exec@10.17.1-canary.1844.22649.0
npm install @auto-canary/first-time-contributor@10.17.1-canary.1844.22649.0
npm install @auto-canary/gem@10.17.1-canary.1844.22649.0
npm install @auto-canary/gh-pages@10.17.1-canary.1844.22649.0
npm install @auto-canary/git-tag@10.17.1-canary.1844.22649.0
npm install @auto-canary/gradle@10.17.1-canary.1844.22649.0
npm install @auto-canary/jira@10.17.1-canary.1844.22649.0
npm install @auto-canary/magic-zero@10.17.1-canary.1844.22649.0
npm install @auto-canary/maven@10.17.1-canary.1844.22649.0
npm install @auto-canary/microsoft-teams@10.17.1-canary.1844.22649.0
npm install @auto-canary/npm@10.17.1-canary.1844.22649.0
npm install @auto-canary/omit-commits@10.17.1-canary.1844.22649.0
npm install @auto-canary/omit-release-notes@10.17.1-canary.1844.22649.0
npm install @auto-canary/pr-body-labels@10.17.1-canary.1844.22649.0
npm install @auto-canary/released@10.17.1-canary.1844.22649.0
npm install @auto-canary/s3@10.17.1-canary.1844.22649.0
npm install @auto-canary/slack@10.17.1-canary.1844.22649.0
npm install @auto-canary/twitter@10.17.1-canary.1844.22649.0
npm install @auto-canary/upload-assets@10.17.1-canary.1844.22649.0
npm install @auto-canary/vscode@10.17.1-canary.1844.22649.0
# or 
yarn add @auto-canary/bot-list@10.17.1-canary.1844.22649.0
yarn add @auto-canary/auto@10.17.1-canary.1844.22649.0
yarn add @auto-canary/core@10.17.1-canary.1844.22649.0
yarn add @auto-canary/package-json-utils@10.17.1-canary.1844.22649.0
yarn add @auto-canary/all-contributors@10.17.1-canary.1844.22649.0
yarn add @auto-canary/brew@10.17.1-canary.1844.22649.0
yarn add @auto-canary/chrome@10.17.1-canary.1844.22649.0
yarn add @auto-canary/cocoapods@10.17.1-canary.1844.22649.0
yarn add @auto-canary/conventional-commits@10.17.1-canary.1844.22649.0
yarn add @auto-canary/crates@10.17.1-canary.1844.22649.0
yarn add @auto-canary/docker@10.17.1-canary.1844.22649.0
yarn add @auto-canary/exec@10.17.1-canary.1844.22649.0
yarn add @auto-canary/first-time-contributor@10.17.1-canary.1844.22649.0
yarn add @auto-canary/gem@10.17.1-canary.1844.22649.0
yarn add @auto-canary/gh-pages@10.17.1-canary.1844.22649.0
yarn add @auto-canary/git-tag@10.17.1-canary.1844.22649.0
yarn add @auto-canary/gradle@10.17.1-canary.1844.22649.0
yarn add @auto-canary/jira@10.17.1-canary.1844.22649.0
yarn add @auto-canary/magic-zero@10.17.1-canary.1844.22649.0
yarn add @auto-canary/maven@10.17.1-canary.1844.22649.0
yarn add @auto-canary/microsoft-teams@10.17.1-canary.1844.22649.0
yarn add @auto-canary/npm@10.17.1-canary.1844.22649.0
yarn add @auto-canary/omit-commits@10.17.1-canary.1844.22649.0
yarn add @auto-canary/omit-release-notes@10.17.1-canary.1844.22649.0
yarn add @auto-canary/pr-body-labels@10.17.1-canary.1844.22649.0
yarn add @auto-canary/released@10.17.1-canary.1844.22649.0
yarn add @auto-canary/s3@10.17.1-canary.1844.22649.0
yarn add @auto-canary/slack@10.17.1-canary.1844.22649.0
yarn add @auto-canary/twitter@10.17.1-canary.1844.22649.0
yarn add @auto-canary/upload-assets@10.17.1-canary.1844.22649.0
yarn add @auto-canary/vscode@10.17.1-canary.1844.22649.0

@adierkens adierkens added the patch Increment the patch version when merged label Mar 2, 2021
@hipstersmoothie hipstersmoothie merged commit 1b90ccc into main Mar 2, 2021
@hipstersmoothie hipstersmoothie deleted the slack-validation-bug branch March 2, 2021 19:26
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.17.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants