Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack message spacing + notification text #1862

Merged
merged 2 commits into from Mar 9, 2021
Merged

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Mar 9, 2021

What Changed

Adds a bit more space to slack changelogs and fixes the notification text

Why

It was displaying "cannot be displayed" in notification

Todo:

  • Add tests

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.1862.22866.gz
auto-macos--canary.1862.22866.gz
auto-win.exe--canary.1862.22866.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.18.4--canary.1862.22866.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.18.4--canary.1862.22866.0
npm install @auto-canary/auto@10.18.4--canary.1862.22866.0
npm install @auto-canary/core@10.18.4--canary.1862.22866.0
npm install @auto-canary/package-json-utils@10.18.4--canary.1862.22866.0
npm install @auto-canary/all-contributors@10.18.4--canary.1862.22866.0
npm install @auto-canary/brew@10.18.4--canary.1862.22866.0
npm install @auto-canary/chrome@10.18.4--canary.1862.22866.0
npm install @auto-canary/cocoapods@10.18.4--canary.1862.22866.0
npm install @auto-canary/conventional-commits@10.18.4--canary.1862.22866.0
npm install @auto-canary/crates@10.18.4--canary.1862.22866.0
npm install @auto-canary/docker@10.18.4--canary.1862.22866.0
npm install @auto-canary/exec@10.18.4--canary.1862.22866.0
npm install @auto-canary/first-time-contributor@10.18.4--canary.1862.22866.0
npm install @auto-canary/gem@10.18.4--canary.1862.22866.0
npm install @auto-canary/gh-pages@10.18.4--canary.1862.22866.0
npm install @auto-canary/git-tag@10.18.4--canary.1862.22866.0
npm install @auto-canary/gradle@10.18.4--canary.1862.22866.0
npm install @auto-canary/jira@10.18.4--canary.1862.22866.0
npm install @auto-canary/magic-zero@10.18.4--canary.1862.22866.0
npm install @auto-canary/maven@10.18.4--canary.1862.22866.0
npm install @auto-canary/microsoft-teams@10.18.4--canary.1862.22866.0
npm install @auto-canary/npm@10.18.4--canary.1862.22866.0
npm install @auto-canary/omit-commits@10.18.4--canary.1862.22866.0
npm install @auto-canary/omit-release-notes@10.18.4--canary.1862.22866.0
npm install @auto-canary/pr-body-labels@10.18.4--canary.1862.22866.0
npm install @auto-canary/released@10.18.4--canary.1862.22866.0
npm install @auto-canary/s3@10.18.4--canary.1862.22866.0
npm install @auto-canary/slack@10.18.4--canary.1862.22866.0
npm install @auto-canary/twitter@10.18.4--canary.1862.22866.0
npm install @auto-canary/upload-assets@10.18.4--canary.1862.22866.0
npm install @auto-canary/vscode@10.18.4--canary.1862.22866.0
# or 
yarn add @auto-canary/bot-list@10.18.4--canary.1862.22866.0
yarn add @auto-canary/auto@10.18.4--canary.1862.22866.0
yarn add @auto-canary/core@10.18.4--canary.1862.22866.0
yarn add @auto-canary/package-json-utils@10.18.4--canary.1862.22866.0
yarn add @auto-canary/all-contributors@10.18.4--canary.1862.22866.0
yarn add @auto-canary/brew@10.18.4--canary.1862.22866.0
yarn add @auto-canary/chrome@10.18.4--canary.1862.22866.0
yarn add @auto-canary/cocoapods@10.18.4--canary.1862.22866.0
yarn add @auto-canary/conventional-commits@10.18.4--canary.1862.22866.0
yarn add @auto-canary/crates@10.18.4--canary.1862.22866.0
yarn add @auto-canary/docker@10.18.4--canary.1862.22866.0
yarn add @auto-canary/exec@10.18.4--canary.1862.22866.0
yarn add @auto-canary/first-time-contributor@10.18.4--canary.1862.22866.0
yarn add @auto-canary/gem@10.18.4--canary.1862.22866.0
yarn add @auto-canary/gh-pages@10.18.4--canary.1862.22866.0
yarn add @auto-canary/git-tag@10.18.4--canary.1862.22866.0
yarn add @auto-canary/gradle@10.18.4--canary.1862.22866.0
yarn add @auto-canary/jira@10.18.4--canary.1862.22866.0
yarn add @auto-canary/magic-zero@10.18.4--canary.1862.22866.0
yarn add @auto-canary/maven@10.18.4--canary.1862.22866.0
yarn add @auto-canary/microsoft-teams@10.18.4--canary.1862.22866.0
yarn add @auto-canary/npm@10.18.4--canary.1862.22866.0
yarn add @auto-canary/omit-commits@10.18.4--canary.1862.22866.0
yarn add @auto-canary/omit-release-notes@10.18.4--canary.1862.22866.0
yarn add @auto-canary/pr-body-labels@10.18.4--canary.1862.22866.0
yarn add @auto-canary/released@10.18.4--canary.1862.22866.0
yarn add @auto-canary/s3@10.18.4--canary.1862.22866.0
yarn add @auto-canary/slack@10.18.4--canary.1862.22866.0
yarn add @auto-canary/twitter@10.18.4--canary.1862.22866.0
yarn add @auto-canary/upload-assets@10.18.4--canary.1862.22866.0
yarn add @auto-canary/vscode@10.18.4--canary.1862.22866.0

@adierkens adierkens added the patch Increment the patch version when merged label Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #1862 (f494c7a) into main (ce9197f) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1862      +/-   ##
==========================================
- Coverage   80.09%   80.09%   -0.01%     
==========================================
  Files          64       64              
  Lines        5145     5149       +4     
  Branches     1203     1204       +1     
==========================================
+ Hits         4121     4124       +3     
- Misses        690      691       +1     
  Partials      334      334              
Impacted Files Coverage Δ
plugins/slack/src/index.ts 77.02% <60.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce9197f...f494c7a. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 3b56060 into main Mar 9, 2021
@hipstersmoothie hipstersmoothie deleted the slack-message-space branch March 9, 2021 18:51
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.18.4 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants