Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap canary identifier in quotes so terminal understands it's an argument to the --preid flag #1864

Merged
merged 2 commits into from Mar 11, 2021

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Mar 11, 2021

What Changed

Why

closes #1863

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.1864.22906.gz
auto-macos--canary.1864.22906.gz
auto-win.exe--canary.1864.22906.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.18.5--canary.1864.22906.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.18.5--canary.1864.22906.0
npm install @auto-canary/auto@10.18.5--canary.1864.22906.0
npm install @auto-canary/core@10.18.5--canary.1864.22906.0
npm install @auto-canary/package-json-utils@10.18.5--canary.1864.22906.0
npm install @auto-canary/all-contributors@10.18.5--canary.1864.22906.0
npm install @auto-canary/brew@10.18.5--canary.1864.22906.0
npm install @auto-canary/chrome@10.18.5--canary.1864.22906.0
npm install @auto-canary/cocoapods@10.18.5--canary.1864.22906.0
npm install @auto-canary/conventional-commits@10.18.5--canary.1864.22906.0
npm install @auto-canary/crates@10.18.5--canary.1864.22906.0
npm install @auto-canary/docker@10.18.5--canary.1864.22906.0
npm install @auto-canary/exec@10.18.5--canary.1864.22906.0
npm install @auto-canary/first-time-contributor@10.18.5--canary.1864.22906.0
npm install @auto-canary/gem@10.18.5--canary.1864.22906.0
npm install @auto-canary/gh-pages@10.18.5--canary.1864.22906.0
npm install @auto-canary/git-tag@10.18.5--canary.1864.22906.0
npm install @auto-canary/gradle@10.18.5--canary.1864.22906.0
npm install @auto-canary/jira@10.18.5--canary.1864.22906.0
npm install @auto-canary/magic-zero@10.18.5--canary.1864.22906.0
npm install @auto-canary/maven@10.18.5--canary.1864.22906.0
npm install @auto-canary/microsoft-teams@10.18.5--canary.1864.22906.0
npm install @auto-canary/npm@10.18.5--canary.1864.22906.0
npm install @auto-canary/omit-commits@10.18.5--canary.1864.22906.0
npm install @auto-canary/omit-release-notes@10.18.5--canary.1864.22906.0
npm install @auto-canary/pr-body-labels@10.18.5--canary.1864.22906.0
npm install @auto-canary/released@10.18.5--canary.1864.22906.0
npm install @auto-canary/s3@10.18.5--canary.1864.22906.0
npm install @auto-canary/slack@10.18.5--canary.1864.22906.0
npm install @auto-canary/twitter@10.18.5--canary.1864.22906.0
npm install @auto-canary/upload-assets@10.18.5--canary.1864.22906.0
npm install @auto-canary/vscode@10.18.5--canary.1864.22906.0
# or 
yarn add @auto-canary/bot-list@10.18.5--canary.1864.22906.0
yarn add @auto-canary/auto@10.18.5--canary.1864.22906.0
yarn add @auto-canary/core@10.18.5--canary.1864.22906.0
yarn add @auto-canary/package-json-utils@10.18.5--canary.1864.22906.0
yarn add @auto-canary/all-contributors@10.18.5--canary.1864.22906.0
yarn add @auto-canary/brew@10.18.5--canary.1864.22906.0
yarn add @auto-canary/chrome@10.18.5--canary.1864.22906.0
yarn add @auto-canary/cocoapods@10.18.5--canary.1864.22906.0
yarn add @auto-canary/conventional-commits@10.18.5--canary.1864.22906.0
yarn add @auto-canary/crates@10.18.5--canary.1864.22906.0
yarn add @auto-canary/docker@10.18.5--canary.1864.22906.0
yarn add @auto-canary/exec@10.18.5--canary.1864.22906.0
yarn add @auto-canary/first-time-contributor@10.18.5--canary.1864.22906.0
yarn add @auto-canary/gem@10.18.5--canary.1864.22906.0
yarn add @auto-canary/gh-pages@10.18.5--canary.1864.22906.0
yarn add @auto-canary/git-tag@10.18.5--canary.1864.22906.0
yarn add @auto-canary/gradle@10.18.5--canary.1864.22906.0
yarn add @auto-canary/jira@10.18.5--canary.1864.22906.0
yarn add @auto-canary/magic-zero@10.18.5--canary.1864.22906.0
yarn add @auto-canary/maven@10.18.5--canary.1864.22906.0
yarn add @auto-canary/microsoft-teams@10.18.5--canary.1864.22906.0
yarn add @auto-canary/npm@10.18.5--canary.1864.22906.0
yarn add @auto-canary/omit-commits@10.18.5--canary.1864.22906.0
yarn add @auto-canary/omit-release-notes@10.18.5--canary.1864.22906.0
yarn add @auto-canary/pr-body-labels@10.18.5--canary.1864.22906.0
yarn add @auto-canary/released@10.18.5--canary.1864.22906.0
yarn add @auto-canary/s3@10.18.5--canary.1864.22906.0
yarn add @auto-canary/slack@10.18.5--canary.1864.22906.0
yarn add @auto-canary/twitter@10.18.5--canary.1864.22906.0
yarn add @auto-canary/upload-assets@10.18.5--canary.1864.22906.0
yarn add @auto-canary/vscode@10.18.5--canary.1864.22906.0

@adierkens adierkens added the patch Increment the patch version when merged label Mar 11, 2021
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #1864 (78d3f6c) into main (f494c7a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1864   +/-   ##
=======================================
  Coverage   80.09%   80.09%           
=======================================
  Files          64       64           
  Lines        5149     5149           
  Branches     1204     1204           
=======================================
  Hits         4124     4124           
  Misses        691      691           
  Partials      334      334           
Impacted Files Coverage Δ
plugins/npm/src/index.ts 73.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f494c7a...78d3f6c. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit b8b05b9 into main Mar 11, 2021
@hipstersmoothie hipstersmoothie deleted the slack-message-space branch March 11, 2021 23:43
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.18.6 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10.18.3 --preid argument change with hyphen prefix breaking the build
2 participants