Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't include private packages in canary install list #1866

Merged
merged 1 commit into from Mar 12, 2021

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Mar 12, 2021

What Changed

see title

Why

Private packages were showing up in canary install list for lerna monorepos

Todo:

  • Add tests

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.1866.22926.gz
auto-macos--canary.1866.22926.gz
auto-win.exe--canary.1866.22926.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.18.7--canary.1866.22926.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.18.7--canary.1866.22926.0
npm install @auto-canary/auto@10.18.7--canary.1866.22926.0
npm install @auto-canary/core@10.18.7--canary.1866.22926.0
npm install @auto-canary/package-json-utils@10.18.7--canary.1866.22926.0
npm install @auto-canary/all-contributors@10.18.7--canary.1866.22926.0
npm install @auto-canary/brew@10.18.7--canary.1866.22926.0
npm install @auto-canary/chrome@10.18.7--canary.1866.22926.0
npm install @auto-canary/cocoapods@10.18.7--canary.1866.22926.0
npm install @auto-canary/conventional-commits@10.18.7--canary.1866.22926.0
npm install @auto-canary/crates@10.18.7--canary.1866.22926.0
npm install @auto-canary/docker@10.18.7--canary.1866.22926.0
npm install @auto-canary/exec@10.18.7--canary.1866.22926.0
npm install @auto-canary/first-time-contributor@10.18.7--canary.1866.22926.0
npm install @auto-canary/gem@10.18.7--canary.1866.22926.0
npm install @auto-canary/gh-pages@10.18.7--canary.1866.22926.0
npm install @auto-canary/git-tag@10.18.7--canary.1866.22926.0
npm install @auto-canary/gradle@10.18.7--canary.1866.22926.0
npm install @auto-canary/jira@10.18.7--canary.1866.22926.0
npm install @auto-canary/magic-zero@10.18.7--canary.1866.22926.0
npm install @auto-canary/maven@10.18.7--canary.1866.22926.0
npm install @auto-canary/microsoft-teams@10.18.7--canary.1866.22926.0
npm install @auto-canary/npm@10.18.7--canary.1866.22926.0
npm install @auto-canary/omit-commits@10.18.7--canary.1866.22926.0
npm install @auto-canary/omit-release-notes@10.18.7--canary.1866.22926.0
npm install @auto-canary/pr-body-labels@10.18.7--canary.1866.22926.0
npm install @auto-canary/released@10.18.7--canary.1866.22926.0
npm install @auto-canary/s3@10.18.7--canary.1866.22926.0
npm install @auto-canary/slack@10.18.7--canary.1866.22926.0
npm install @auto-canary/twitter@10.18.7--canary.1866.22926.0
npm install @auto-canary/upload-assets@10.18.7--canary.1866.22926.0
npm install @auto-canary/vscode@10.18.7--canary.1866.22926.0
# or 
yarn add @auto-canary/bot-list@10.18.7--canary.1866.22926.0
yarn add @auto-canary/auto@10.18.7--canary.1866.22926.0
yarn add @auto-canary/core@10.18.7--canary.1866.22926.0
yarn add @auto-canary/package-json-utils@10.18.7--canary.1866.22926.0
yarn add @auto-canary/all-contributors@10.18.7--canary.1866.22926.0
yarn add @auto-canary/brew@10.18.7--canary.1866.22926.0
yarn add @auto-canary/chrome@10.18.7--canary.1866.22926.0
yarn add @auto-canary/cocoapods@10.18.7--canary.1866.22926.0
yarn add @auto-canary/conventional-commits@10.18.7--canary.1866.22926.0
yarn add @auto-canary/crates@10.18.7--canary.1866.22926.0
yarn add @auto-canary/docker@10.18.7--canary.1866.22926.0
yarn add @auto-canary/exec@10.18.7--canary.1866.22926.0
yarn add @auto-canary/first-time-contributor@10.18.7--canary.1866.22926.0
yarn add @auto-canary/gem@10.18.7--canary.1866.22926.0
yarn add @auto-canary/gh-pages@10.18.7--canary.1866.22926.0
yarn add @auto-canary/git-tag@10.18.7--canary.1866.22926.0
yarn add @auto-canary/gradle@10.18.7--canary.1866.22926.0
yarn add @auto-canary/jira@10.18.7--canary.1866.22926.0
yarn add @auto-canary/magic-zero@10.18.7--canary.1866.22926.0
yarn add @auto-canary/maven@10.18.7--canary.1866.22926.0
yarn add @auto-canary/microsoft-teams@10.18.7--canary.1866.22926.0
yarn add @auto-canary/npm@10.18.7--canary.1866.22926.0
yarn add @auto-canary/omit-commits@10.18.7--canary.1866.22926.0
yarn add @auto-canary/omit-release-notes@10.18.7--canary.1866.22926.0
yarn add @auto-canary/pr-body-labels@10.18.7--canary.1866.22926.0
yarn add @auto-canary/released@10.18.7--canary.1866.22926.0
yarn add @auto-canary/s3@10.18.7--canary.1866.22926.0
yarn add @auto-canary/slack@10.18.7--canary.1866.22926.0
yarn add @auto-canary/twitter@10.18.7--canary.1866.22926.0
yarn add @auto-canary/upload-assets@10.18.7--canary.1866.22926.0
yarn add @auto-canary/vscode@10.18.7--canary.1866.22926.0

@adierkens adierkens added the patch Increment the patch version when merged label Mar 12, 2021
@hipstersmoothie hipstersmoothie merged commit fe12724 into main Mar 12, 2021
@hipstersmoothie hipstersmoothie deleted the private-lerna-packages branch March 12, 2021 00:09
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.18.7 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants