Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better exclude for lerna private packages #1876

Merged
merged 1 commit into from Mar 14, 2021
Merged

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Mar 14, 2021

What Changed

We were only excluding packages without a version, this now also exclude packages with a version but marked as private.

Why

Discussion in #1861

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.1876.23063.gz
auto-macos--canary.1876.23063.gz
auto-win.exe--canary.1876.23063.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.20.1--canary.1876.23063.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.20.1--canary.1876.23063.0
npm install @auto-canary/auto@10.20.1--canary.1876.23063.0
npm install @auto-canary/core@10.20.1--canary.1876.23063.0
npm install @auto-canary/package-json-utils@10.20.1--canary.1876.23063.0
npm install @auto-canary/all-contributors@10.20.1--canary.1876.23063.0
npm install @auto-canary/brew@10.20.1--canary.1876.23063.0
npm install @auto-canary/chrome@10.20.1--canary.1876.23063.0
npm install @auto-canary/cocoapods@10.20.1--canary.1876.23063.0
npm install @auto-canary/conventional-commits@10.20.1--canary.1876.23063.0
npm install @auto-canary/crates@10.20.1--canary.1876.23063.0
npm install @auto-canary/docker@10.20.1--canary.1876.23063.0
npm install @auto-canary/exec@10.20.1--canary.1876.23063.0
npm install @auto-canary/first-time-contributor@10.20.1--canary.1876.23063.0
npm install @auto-canary/gem@10.20.1--canary.1876.23063.0
npm install @auto-canary/gh-pages@10.20.1--canary.1876.23063.0
npm install @auto-canary/git-tag@10.20.1--canary.1876.23063.0
npm install @auto-canary/gradle@10.20.1--canary.1876.23063.0
npm install @auto-canary/jira@10.20.1--canary.1876.23063.0
npm install @auto-canary/magic-zero@10.20.1--canary.1876.23063.0
npm install @auto-canary/maven@10.20.1--canary.1876.23063.0
npm install @auto-canary/microsoft-teams@10.20.1--canary.1876.23063.0
npm install @auto-canary/npm@10.20.1--canary.1876.23063.0
npm install @auto-canary/omit-commits@10.20.1--canary.1876.23063.0
npm install @auto-canary/omit-release-notes@10.20.1--canary.1876.23063.0
npm install @auto-canary/pr-body-labels@10.20.1--canary.1876.23063.0
npm install @auto-canary/released@10.20.1--canary.1876.23063.0
npm install @auto-canary/s3@10.20.1--canary.1876.23063.0
npm install @auto-canary/slack@10.20.1--canary.1876.23063.0
npm install @auto-canary/twitter@10.20.1--canary.1876.23063.0
npm install @auto-canary/upload-assets@10.20.1--canary.1876.23063.0
npm install @auto-canary/vscode@10.20.1--canary.1876.23063.0
# or 
yarn add @auto-canary/bot-list@10.20.1--canary.1876.23063.0
yarn add @auto-canary/auto@10.20.1--canary.1876.23063.0
yarn add @auto-canary/core@10.20.1--canary.1876.23063.0
yarn add @auto-canary/package-json-utils@10.20.1--canary.1876.23063.0
yarn add @auto-canary/all-contributors@10.20.1--canary.1876.23063.0
yarn add @auto-canary/brew@10.20.1--canary.1876.23063.0
yarn add @auto-canary/chrome@10.20.1--canary.1876.23063.0
yarn add @auto-canary/cocoapods@10.20.1--canary.1876.23063.0
yarn add @auto-canary/conventional-commits@10.20.1--canary.1876.23063.0
yarn add @auto-canary/crates@10.20.1--canary.1876.23063.0
yarn add @auto-canary/docker@10.20.1--canary.1876.23063.0
yarn add @auto-canary/exec@10.20.1--canary.1876.23063.0
yarn add @auto-canary/first-time-contributor@10.20.1--canary.1876.23063.0
yarn add @auto-canary/gem@10.20.1--canary.1876.23063.0
yarn add @auto-canary/gh-pages@10.20.1--canary.1876.23063.0
yarn add @auto-canary/git-tag@10.20.1--canary.1876.23063.0
yarn add @auto-canary/gradle@10.20.1--canary.1876.23063.0
yarn add @auto-canary/jira@10.20.1--canary.1876.23063.0
yarn add @auto-canary/magic-zero@10.20.1--canary.1876.23063.0
yarn add @auto-canary/maven@10.20.1--canary.1876.23063.0
yarn add @auto-canary/microsoft-teams@10.20.1--canary.1876.23063.0
yarn add @auto-canary/npm@10.20.1--canary.1876.23063.0
yarn add @auto-canary/omit-commits@10.20.1--canary.1876.23063.0
yarn add @auto-canary/omit-release-notes@10.20.1--canary.1876.23063.0
yarn add @auto-canary/pr-body-labels@10.20.1--canary.1876.23063.0
yarn add @auto-canary/released@10.20.1--canary.1876.23063.0
yarn add @auto-canary/s3@10.20.1--canary.1876.23063.0
yarn add @auto-canary/slack@10.20.1--canary.1876.23063.0
yarn add @auto-canary/twitter@10.20.1--canary.1876.23063.0
yarn add @auto-canary/upload-assets@10.20.1--canary.1876.23063.0
yarn add @auto-canary/vscode@10.20.1--canary.1876.23063.0

@adierkens adierkens added the patch Increment the patch version when merged label Mar 14, 2021
@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #1876 (35b39df) into main (e23a9f2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1876   +/-   ##
=======================================
  Coverage   80.18%   80.18%           
=======================================
  Files          65       65           
  Lines        5163     5163           
  Branches     1208     1208           
=======================================
  Hits         4140     4140           
  Misses        688      688           
  Partials      335      335           
Impacted Files Coverage Δ
packages/core/src/utils/get-lerna-packages.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f2f02...35b39df. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit b051e65 into main Mar 14, 2021
@hipstersmoothie hipstersmoothie deleted the private-exclude branch March 14, 2021 19:19
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.20.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants