Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add defaultReleaseType option #1911

Merged
merged 1 commit into from Mar 22, 2021

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Mar 22, 2021

What Changed

Add the ability to control default release type when any non-semver conventional commit message is found

Why

closes #1910

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.1911.23448.gz
auto-macos--canary.1911.23448.gz
auto-win.exe--canary.1911.23448.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.22.0--canary.1911.23448.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.22.0--canary.1911.23448.0
npm install @auto-canary/auto@10.22.0--canary.1911.23448.0
npm install @auto-canary/core@10.22.0--canary.1911.23448.0
npm install @auto-canary/package-json-utils@10.22.0--canary.1911.23448.0
npm install @auto-canary/all-contributors@10.22.0--canary.1911.23448.0
npm install @auto-canary/brew@10.22.0--canary.1911.23448.0
npm install @auto-canary/chrome@10.22.0--canary.1911.23448.0
npm install @auto-canary/cocoapods@10.22.0--canary.1911.23448.0
npm install @auto-canary/conventional-commits@10.22.0--canary.1911.23448.0
npm install @auto-canary/crates@10.22.0--canary.1911.23448.0
npm install @auto-canary/docker@10.22.0--canary.1911.23448.0
npm install @auto-canary/exec@10.22.0--canary.1911.23448.0
npm install @auto-canary/first-time-contributor@10.22.0--canary.1911.23448.0
npm install @auto-canary/gem@10.22.0--canary.1911.23448.0
npm install @auto-canary/gh-pages@10.22.0--canary.1911.23448.0
npm install @auto-canary/git-tag@10.22.0--canary.1911.23448.0
npm install @auto-canary/gradle@10.22.0--canary.1911.23448.0
npm install @auto-canary/jira@10.22.0--canary.1911.23448.0
npm install @auto-canary/magic-zero@10.22.0--canary.1911.23448.0
npm install @auto-canary/maven@10.22.0--canary.1911.23448.0
npm install @auto-canary/microsoft-teams@10.22.0--canary.1911.23448.0
npm install @auto-canary/npm@10.22.0--canary.1911.23448.0
npm install @auto-canary/omit-commits@10.22.0--canary.1911.23448.0
npm install @auto-canary/omit-release-notes@10.22.0--canary.1911.23448.0
npm install @auto-canary/pr-body-labels@10.22.0--canary.1911.23448.0
npm install @auto-canary/released@10.22.0--canary.1911.23448.0
npm install @auto-canary/s3@10.22.0--canary.1911.23448.0
npm install @auto-canary/slack@10.22.0--canary.1911.23448.0
npm install @auto-canary/twitter@10.22.0--canary.1911.23448.0
npm install @auto-canary/upload-assets@10.22.0--canary.1911.23448.0
npm install @auto-canary/vscode@10.22.0--canary.1911.23448.0
# or 
yarn add @auto-canary/bot-list@10.22.0--canary.1911.23448.0
yarn add @auto-canary/auto@10.22.0--canary.1911.23448.0
yarn add @auto-canary/core@10.22.0--canary.1911.23448.0
yarn add @auto-canary/package-json-utils@10.22.0--canary.1911.23448.0
yarn add @auto-canary/all-contributors@10.22.0--canary.1911.23448.0
yarn add @auto-canary/brew@10.22.0--canary.1911.23448.0
yarn add @auto-canary/chrome@10.22.0--canary.1911.23448.0
yarn add @auto-canary/cocoapods@10.22.0--canary.1911.23448.0
yarn add @auto-canary/conventional-commits@10.22.0--canary.1911.23448.0
yarn add @auto-canary/crates@10.22.0--canary.1911.23448.0
yarn add @auto-canary/docker@10.22.0--canary.1911.23448.0
yarn add @auto-canary/exec@10.22.0--canary.1911.23448.0
yarn add @auto-canary/first-time-contributor@10.22.0--canary.1911.23448.0
yarn add @auto-canary/gem@10.22.0--canary.1911.23448.0
yarn add @auto-canary/gh-pages@10.22.0--canary.1911.23448.0
yarn add @auto-canary/git-tag@10.22.0--canary.1911.23448.0
yarn add @auto-canary/gradle@10.22.0--canary.1911.23448.0
yarn add @auto-canary/jira@10.22.0--canary.1911.23448.0
yarn add @auto-canary/magic-zero@10.22.0--canary.1911.23448.0
yarn add @auto-canary/maven@10.22.0--canary.1911.23448.0
yarn add @auto-canary/microsoft-teams@10.22.0--canary.1911.23448.0
yarn add @auto-canary/npm@10.22.0--canary.1911.23448.0
yarn add @auto-canary/omit-commits@10.22.0--canary.1911.23448.0
yarn add @auto-canary/omit-release-notes@10.22.0--canary.1911.23448.0
yarn add @auto-canary/pr-body-labels@10.22.0--canary.1911.23448.0
yarn add @auto-canary/released@10.22.0--canary.1911.23448.0
yarn add @auto-canary/s3@10.22.0--canary.1911.23448.0
yarn add @auto-canary/slack@10.22.0--canary.1911.23448.0
yarn add @auto-canary/twitter@10.22.0--canary.1911.23448.0
yarn add @auto-canary/upload-assets@10.22.0--canary.1911.23448.0
yarn add @auto-canary/vscode@10.22.0--canary.1911.23448.0

@adierkens adierkens added the minor Increment the minor version when merged label Mar 22, 2021
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #1911 (bcd3146) into main (fabca44) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1911   +/-   ##
=======================================
  Coverage   80.13%   80.13%           
=======================================
  Files          65       65           
  Lines        5225     5225           
  Branches     1220     1221    +1     
=======================================
  Hits         4187     4187           
  Misses        692      692           
  Partials      346      346           
Impacted Files Coverage Δ
plugins/conventional-commits/src/index.ts 76.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fabca44...bcd3146. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 6737ad6 into main Mar 22, 2021
@hipstersmoothie hipstersmoothie deleted the conv-commits-default-release-type branch March 22, 2021 22:30
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.22.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release not created, when expected to have a release created
2 participants