Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rendering long lines in slack plugin #1913

Merged
merged 1 commit into from Mar 24, 2021

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Mar 24, 2021

Why

closes #1854

Todo:

  • Add tests

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.1913.23541.gz
auto-macos--canary.1913.23541.gz
auto-win.exe--canary.1913.23541.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.22.1--canary.1913.23541.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.22.1--canary.1913.23541.0
npm install @auto-canary/auto@10.22.1--canary.1913.23541.0
npm install @auto-canary/core@10.22.1--canary.1913.23541.0
npm install @auto-canary/package-json-utils@10.22.1--canary.1913.23541.0
npm install @auto-canary/all-contributors@10.22.1--canary.1913.23541.0
npm install @auto-canary/brew@10.22.1--canary.1913.23541.0
npm install @auto-canary/chrome@10.22.1--canary.1913.23541.0
npm install @auto-canary/cocoapods@10.22.1--canary.1913.23541.0
npm install @auto-canary/conventional-commits@10.22.1--canary.1913.23541.0
npm install @auto-canary/crates@10.22.1--canary.1913.23541.0
npm install @auto-canary/docker@10.22.1--canary.1913.23541.0
npm install @auto-canary/exec@10.22.1--canary.1913.23541.0
npm install @auto-canary/first-time-contributor@10.22.1--canary.1913.23541.0
npm install @auto-canary/gem@10.22.1--canary.1913.23541.0
npm install @auto-canary/gh-pages@10.22.1--canary.1913.23541.0
npm install @auto-canary/git-tag@10.22.1--canary.1913.23541.0
npm install @auto-canary/gradle@10.22.1--canary.1913.23541.0
npm install @auto-canary/jira@10.22.1--canary.1913.23541.0
npm install @auto-canary/magic-zero@10.22.1--canary.1913.23541.0
npm install @auto-canary/maven@10.22.1--canary.1913.23541.0
npm install @auto-canary/microsoft-teams@10.22.1--canary.1913.23541.0
npm install @auto-canary/npm@10.22.1--canary.1913.23541.0
npm install @auto-canary/omit-commits@10.22.1--canary.1913.23541.0
npm install @auto-canary/omit-release-notes@10.22.1--canary.1913.23541.0
npm install @auto-canary/pr-body-labels@10.22.1--canary.1913.23541.0
npm install @auto-canary/released@10.22.1--canary.1913.23541.0
npm install @auto-canary/s3@10.22.1--canary.1913.23541.0
npm install @auto-canary/slack@10.22.1--canary.1913.23541.0
npm install @auto-canary/twitter@10.22.1--canary.1913.23541.0
npm install @auto-canary/upload-assets@10.22.1--canary.1913.23541.0
npm install @auto-canary/vscode@10.22.1--canary.1913.23541.0
# or 
yarn add @auto-canary/bot-list@10.22.1--canary.1913.23541.0
yarn add @auto-canary/auto@10.22.1--canary.1913.23541.0
yarn add @auto-canary/core@10.22.1--canary.1913.23541.0
yarn add @auto-canary/package-json-utils@10.22.1--canary.1913.23541.0
yarn add @auto-canary/all-contributors@10.22.1--canary.1913.23541.0
yarn add @auto-canary/brew@10.22.1--canary.1913.23541.0
yarn add @auto-canary/chrome@10.22.1--canary.1913.23541.0
yarn add @auto-canary/cocoapods@10.22.1--canary.1913.23541.0
yarn add @auto-canary/conventional-commits@10.22.1--canary.1913.23541.0
yarn add @auto-canary/crates@10.22.1--canary.1913.23541.0
yarn add @auto-canary/docker@10.22.1--canary.1913.23541.0
yarn add @auto-canary/exec@10.22.1--canary.1913.23541.0
yarn add @auto-canary/first-time-contributor@10.22.1--canary.1913.23541.0
yarn add @auto-canary/gem@10.22.1--canary.1913.23541.0
yarn add @auto-canary/gh-pages@10.22.1--canary.1913.23541.0
yarn add @auto-canary/git-tag@10.22.1--canary.1913.23541.0
yarn add @auto-canary/gradle@10.22.1--canary.1913.23541.0
yarn add @auto-canary/jira@10.22.1--canary.1913.23541.0
yarn add @auto-canary/magic-zero@10.22.1--canary.1913.23541.0
yarn add @auto-canary/maven@10.22.1--canary.1913.23541.0
yarn add @auto-canary/microsoft-teams@10.22.1--canary.1913.23541.0
yarn add @auto-canary/npm@10.22.1--canary.1913.23541.0
yarn add @auto-canary/omit-commits@10.22.1--canary.1913.23541.0
yarn add @auto-canary/omit-release-notes@10.22.1--canary.1913.23541.0
yarn add @auto-canary/pr-body-labels@10.22.1--canary.1913.23541.0
yarn add @auto-canary/released@10.22.1--canary.1913.23541.0
yarn add @auto-canary/s3@10.22.1--canary.1913.23541.0
yarn add @auto-canary/slack@10.22.1--canary.1913.23541.0
yarn add @auto-canary/twitter@10.22.1--canary.1913.23541.0
yarn add @auto-canary/upload-assets@10.22.1--canary.1913.23541.0
yarn add @auto-canary/vscode@10.22.1--canary.1913.23541.0

@hipstersmoothie hipstersmoothie force-pushed the conv-commits-default-release-type branch from 97e17e8 to cd6aed9 Compare March 24, 2021 00:34
@adierkens adierkens added the patch Increment the patch version when merged label Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #1913 (cd6aed9) into main (925bdfe) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1913      +/-   ##
==========================================
+ Coverage   80.13%   80.19%   +0.06%     
==========================================
  Files          65       65              
  Lines        5225     5241      +16     
  Branches     1221     1223       +2     
==========================================
+ Hits         4187     4203      +16     
  Misses        692      692              
  Partials      346      346              
Impacted Files Coverage Δ
plugins/slack/src/index.ts 79.26% <100.00%> (+2.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 925bdfe...cd6aed9. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 3f4c51e into main Mar 24, 2021
@hipstersmoothie hipstersmoothie deleted the conv-commits-default-release-type branch March 24, 2021 01:37
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.22.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slack plugin breaks with long release notes
2 participants