Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Command: Tag creation fallback. #1929

Merged
merged 4 commits into from Mar 29, 2021
Merged

Release Command: Tag creation fallback. #1929

merged 4 commits into from Mar 29, 2021

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Mar 29, 2021

Release Notes

When creating a release for a tag that isn't on the remote, fallback to creating a tag pointing at the --to option.

Why

closes #1917

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.1929.23689.gz
auto-macos--canary.1929.23689.gz
auto-win.exe--canary.1929.23689.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.24.0--canary.1929.23688.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.24.0--canary.1929.23688.0
npm install @auto-canary/auto@10.24.0--canary.1929.23688.0
npm install @auto-canary/core@10.24.0--canary.1929.23688.0
npm install @auto-canary/package-json-utils@10.24.0--canary.1929.23688.0
npm install @auto-canary/all-contributors@10.24.0--canary.1929.23688.0
npm install @auto-canary/brew@10.24.0--canary.1929.23688.0
npm install @auto-canary/chrome@10.24.0--canary.1929.23688.0
npm install @auto-canary/cocoapods@10.24.0--canary.1929.23688.0
npm install @auto-canary/conventional-commits@10.24.0--canary.1929.23688.0
npm install @auto-canary/crates@10.24.0--canary.1929.23688.0
npm install @auto-canary/docker@10.24.0--canary.1929.23688.0
npm install @auto-canary/exec@10.24.0--canary.1929.23688.0
npm install @auto-canary/first-time-contributor@10.24.0--canary.1929.23688.0
npm install @auto-canary/gem@10.24.0--canary.1929.23688.0
npm install @auto-canary/gh-pages@10.24.0--canary.1929.23688.0
npm install @auto-canary/git-tag@10.24.0--canary.1929.23688.0
npm install @auto-canary/gradle@10.24.0--canary.1929.23688.0
npm install @auto-canary/jira@10.24.0--canary.1929.23688.0
npm install @auto-canary/magic-zero@10.24.0--canary.1929.23688.0
npm install @auto-canary/maven@10.24.0--canary.1929.23688.0
npm install @auto-canary/microsoft-teams@10.24.0--canary.1929.23688.0
npm install @auto-canary/npm@10.24.0--canary.1929.23688.0
npm install @auto-canary/omit-commits@10.24.0--canary.1929.23688.0
npm install @auto-canary/omit-release-notes@10.24.0--canary.1929.23688.0
npm install @auto-canary/pr-body-labels@10.24.0--canary.1929.23688.0
npm install @auto-canary/released@10.24.0--canary.1929.23688.0
npm install @auto-canary/s3@10.24.0--canary.1929.23688.0
npm install @auto-canary/slack@10.24.0--canary.1929.23688.0
npm install @auto-canary/twitter@10.24.0--canary.1929.23688.0
npm install @auto-canary/upload-assets@10.24.0--canary.1929.23688.0
npm install @auto-canary/vscode@10.24.0--canary.1929.23688.0
# or 
yarn add @auto-canary/bot-list@10.24.0--canary.1929.23688.0
yarn add @auto-canary/auto@10.24.0--canary.1929.23688.0
yarn add @auto-canary/core@10.24.0--canary.1929.23688.0
yarn add @auto-canary/package-json-utils@10.24.0--canary.1929.23688.0
yarn add @auto-canary/all-contributors@10.24.0--canary.1929.23688.0
yarn add @auto-canary/brew@10.24.0--canary.1929.23688.0
yarn add @auto-canary/chrome@10.24.0--canary.1929.23688.0
yarn add @auto-canary/cocoapods@10.24.0--canary.1929.23688.0
yarn add @auto-canary/conventional-commits@10.24.0--canary.1929.23688.0
yarn add @auto-canary/crates@10.24.0--canary.1929.23688.0
yarn add @auto-canary/docker@10.24.0--canary.1929.23688.0
yarn add @auto-canary/exec@10.24.0--canary.1929.23688.0
yarn add @auto-canary/first-time-contributor@10.24.0--canary.1929.23688.0
yarn add @auto-canary/gem@10.24.0--canary.1929.23688.0
yarn add @auto-canary/gh-pages@10.24.0--canary.1929.23688.0
yarn add @auto-canary/git-tag@10.24.0--canary.1929.23688.0
yarn add @auto-canary/gradle@10.24.0--canary.1929.23688.0
yarn add @auto-canary/jira@10.24.0--canary.1929.23688.0
yarn add @auto-canary/magic-zero@10.24.0--canary.1929.23688.0
yarn add @auto-canary/maven@10.24.0--canary.1929.23688.0
yarn add @auto-canary/microsoft-teams@10.24.0--canary.1929.23688.0
yarn add @auto-canary/npm@10.24.0--canary.1929.23688.0
yarn add @auto-canary/omit-commits@10.24.0--canary.1929.23688.0
yarn add @auto-canary/omit-release-notes@10.24.0--canary.1929.23688.0
yarn add @auto-canary/pr-body-labels@10.24.0--canary.1929.23688.0
yarn add @auto-canary/released@10.24.0--canary.1929.23688.0
yarn add @auto-canary/s3@10.24.0--canary.1929.23688.0
yarn add @auto-canary/slack@10.24.0--canary.1929.23688.0
yarn add @auto-canary/twitter@10.24.0--canary.1929.23688.0
yarn add @auto-canary/upload-assets@10.24.0--canary.1929.23688.0
yarn add @auto-canary/vscode@10.24.0--canary.1929.23688.0

@hipstersmoothie hipstersmoothie force-pushed the release-flag branch 2 times, most recently from 5ab9523 to 8eac23f Compare March 29, 2021 23:21
@adierkens adierkens added the minor Increment the minor version when merged label Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #1929 (8eac23f) into main (f25f2d6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8eac23f differs from pull request most recent head cca314f. Consider uploading reports for the commit cca314f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1929   +/-   ##
=======================================
  Coverage   80.20%   80.21%           
=======================================
  Files          65       65           
  Lines        5255     5257    +2     
  Branches     1228     1230    +2     
=======================================
+ Hits         4215     4217    +2     
  Misses        693      693           
  Partials      347      347           
Impacted Files Coverage Δ
packages/cli/src/parse-args.ts 97.43% <ø> (ø)
packages/core/src/auto.ts 77.91% <100.00%> (+0.02%) ⬆️
packages/core/src/git.ts 87.77% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6505c79...cca314f. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 915b105 into main Mar 29, 2021
@hipstersmoothie hipstersmoothie deleted the release-flag branch March 29, 2021 23:38
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.24.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to target a specific commit for a github release
2 participants