Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable using globally installed plugins #1930

Merged
merged 1 commit into from Mar 30, 2021
Merged

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Mar 29, 2021

What Changed

I thought that require would fall back to global packages but it turns out it doesn't. This PR adds a package that checks a few common global places.

Why

closes #1915

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.1930.23715.gz
auto-macos--canary.1930.23715.gz
auto-win.exe--canary.1930.23715.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.24.1--canary.1930.23715.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.24.1--canary.1930.23715.0
npm install @auto-canary/auto@10.24.1--canary.1930.23715.0
npm install @auto-canary/core@10.24.1--canary.1930.23715.0
npm install @auto-canary/package-json-utils@10.24.1--canary.1930.23715.0
npm install @auto-canary/all-contributors@10.24.1--canary.1930.23715.0
npm install @auto-canary/brew@10.24.1--canary.1930.23715.0
npm install @auto-canary/chrome@10.24.1--canary.1930.23715.0
npm install @auto-canary/cocoapods@10.24.1--canary.1930.23715.0
npm install @auto-canary/conventional-commits@10.24.1--canary.1930.23715.0
npm install @auto-canary/crates@10.24.1--canary.1930.23715.0
npm install @auto-canary/docker@10.24.1--canary.1930.23715.0
npm install @auto-canary/exec@10.24.1--canary.1930.23715.0
npm install @auto-canary/first-time-contributor@10.24.1--canary.1930.23715.0
npm install @auto-canary/gem@10.24.1--canary.1930.23715.0
npm install @auto-canary/gh-pages@10.24.1--canary.1930.23715.0
npm install @auto-canary/git-tag@10.24.1--canary.1930.23715.0
npm install @auto-canary/gradle@10.24.1--canary.1930.23715.0
npm install @auto-canary/jira@10.24.1--canary.1930.23715.0
npm install @auto-canary/magic-zero@10.24.1--canary.1930.23715.0
npm install @auto-canary/maven@10.24.1--canary.1930.23715.0
npm install @auto-canary/microsoft-teams@10.24.1--canary.1930.23715.0
npm install @auto-canary/npm@10.24.1--canary.1930.23715.0
npm install @auto-canary/omit-commits@10.24.1--canary.1930.23715.0
npm install @auto-canary/omit-release-notes@10.24.1--canary.1930.23715.0
npm install @auto-canary/pr-body-labels@10.24.1--canary.1930.23715.0
npm install @auto-canary/released@10.24.1--canary.1930.23715.0
npm install @auto-canary/s3@10.24.1--canary.1930.23715.0
npm install @auto-canary/slack@10.24.1--canary.1930.23715.0
npm install @auto-canary/twitter@10.24.1--canary.1930.23715.0
npm install @auto-canary/upload-assets@10.24.1--canary.1930.23715.0
npm install @auto-canary/vscode@10.24.1--canary.1930.23715.0
# or 
yarn add @auto-canary/bot-list@10.24.1--canary.1930.23715.0
yarn add @auto-canary/auto@10.24.1--canary.1930.23715.0
yarn add @auto-canary/core@10.24.1--canary.1930.23715.0
yarn add @auto-canary/package-json-utils@10.24.1--canary.1930.23715.0
yarn add @auto-canary/all-contributors@10.24.1--canary.1930.23715.0
yarn add @auto-canary/brew@10.24.1--canary.1930.23715.0
yarn add @auto-canary/chrome@10.24.1--canary.1930.23715.0
yarn add @auto-canary/cocoapods@10.24.1--canary.1930.23715.0
yarn add @auto-canary/conventional-commits@10.24.1--canary.1930.23715.0
yarn add @auto-canary/crates@10.24.1--canary.1930.23715.0
yarn add @auto-canary/docker@10.24.1--canary.1930.23715.0
yarn add @auto-canary/exec@10.24.1--canary.1930.23715.0
yarn add @auto-canary/first-time-contributor@10.24.1--canary.1930.23715.0
yarn add @auto-canary/gem@10.24.1--canary.1930.23715.0
yarn add @auto-canary/gh-pages@10.24.1--canary.1930.23715.0
yarn add @auto-canary/git-tag@10.24.1--canary.1930.23715.0
yarn add @auto-canary/gradle@10.24.1--canary.1930.23715.0
yarn add @auto-canary/jira@10.24.1--canary.1930.23715.0
yarn add @auto-canary/magic-zero@10.24.1--canary.1930.23715.0
yarn add @auto-canary/maven@10.24.1--canary.1930.23715.0
yarn add @auto-canary/microsoft-teams@10.24.1--canary.1930.23715.0
yarn add @auto-canary/npm@10.24.1--canary.1930.23715.0
yarn add @auto-canary/omit-commits@10.24.1--canary.1930.23715.0
yarn add @auto-canary/omit-release-notes@10.24.1--canary.1930.23715.0
yarn add @auto-canary/pr-body-labels@10.24.1--canary.1930.23715.0
yarn add @auto-canary/released@10.24.1--canary.1930.23715.0
yarn add @auto-canary/s3@10.24.1--canary.1930.23715.0
yarn add @auto-canary/slack@10.24.1--canary.1930.23715.0
yarn add @auto-canary/twitter@10.24.1--canary.1930.23715.0
yarn add @auto-canary/upload-assets@10.24.1--canary.1930.23715.0
yarn add @auto-canary/vscode@10.24.1--canary.1930.23715.0

@adierkens adierkens added the patch Increment the patch version when merged label Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #1930 (268711d) into main (915b105) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1930   +/-   ##
=======================================
  Coverage   80.21%   80.22%           
=======================================
  Files          65       65           
  Lines        5257     5258    +1     
  Branches     1230     1230           
=======================================
+ Hits         4217     4218    +1     
  Misses        693      693           
  Partials      347      347           
Impacted Files Coverage Δ
packages/core/src/utils/try-require.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 915b105...268711d. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit f4f4a86 into main Mar 30, 2021
@hipstersmoothie hipstersmoothie deleted the global-packages branch March 30, 2021 00:26
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.24.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Non-npm] Custom plugin not found
2 participants