Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer npx over yarn for running lerna commands #1936

Merged
merged 2 commits into from Apr 9, 2021

Conversation

zephraph
Copy link
Collaborator

@zephraph zephraph commented Apr 7, 2021

Fixes #1933

What Changed

Replaces yarn with npx when invoking the lerna bin

Why

While lerna is often used with yarn (to leverage yarn workspaces) it doesn't necessitate the usage of yarn. As is pointed out in #1933, this adds an implicit global dependency that's unnecessary.

While this works, all we're really doing here is using npx (previously yarn) for path aliasing to the .bin dir. At some point maybe we should just roll a custom version of that logic into execPromise and remove the implicit dependency on npx too.

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.1936.23773.gz
auto-macos--canary.1936.23773.gz
auto-win.exe--canary.1936.23773.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.24.2--canary.1936.23773.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.24.2--canary.1936.23773.0
npm install @auto-canary/auto@10.24.2--canary.1936.23773.0
npm install @auto-canary/core@10.24.2--canary.1936.23773.0
npm install @auto-canary/package-json-utils@10.24.2--canary.1936.23773.0
npm install @auto-canary/all-contributors@10.24.2--canary.1936.23773.0
npm install @auto-canary/brew@10.24.2--canary.1936.23773.0
npm install @auto-canary/chrome@10.24.2--canary.1936.23773.0
npm install @auto-canary/cocoapods@10.24.2--canary.1936.23773.0
npm install @auto-canary/conventional-commits@10.24.2--canary.1936.23773.0
npm install @auto-canary/crates@10.24.2--canary.1936.23773.0
npm install @auto-canary/docker@10.24.2--canary.1936.23773.0
npm install @auto-canary/exec@10.24.2--canary.1936.23773.0
npm install @auto-canary/first-time-contributor@10.24.2--canary.1936.23773.0
npm install @auto-canary/gem@10.24.2--canary.1936.23773.0
npm install @auto-canary/gh-pages@10.24.2--canary.1936.23773.0
npm install @auto-canary/git-tag@10.24.2--canary.1936.23773.0
npm install @auto-canary/gradle@10.24.2--canary.1936.23773.0
npm install @auto-canary/jira@10.24.2--canary.1936.23773.0
npm install @auto-canary/magic-zero@10.24.2--canary.1936.23773.0
npm install @auto-canary/maven@10.24.2--canary.1936.23773.0
npm install @auto-canary/microsoft-teams@10.24.2--canary.1936.23773.0
npm install @auto-canary/npm@10.24.2--canary.1936.23773.0
npm install @auto-canary/omit-commits@10.24.2--canary.1936.23773.0
npm install @auto-canary/omit-release-notes@10.24.2--canary.1936.23773.0
npm install @auto-canary/pr-body-labels@10.24.2--canary.1936.23773.0
npm install @auto-canary/released@10.24.2--canary.1936.23773.0
npm install @auto-canary/s3@10.24.2--canary.1936.23773.0
npm install @auto-canary/slack@10.24.2--canary.1936.23773.0
npm install @auto-canary/twitter@10.24.2--canary.1936.23773.0
npm install @auto-canary/upload-assets@10.24.2--canary.1936.23773.0
npm install @auto-canary/vscode@10.24.2--canary.1936.23773.0
# or 
yarn add @auto-canary/bot-list@10.24.2--canary.1936.23773.0
yarn add @auto-canary/auto@10.24.2--canary.1936.23773.0
yarn add @auto-canary/core@10.24.2--canary.1936.23773.0
yarn add @auto-canary/package-json-utils@10.24.2--canary.1936.23773.0
yarn add @auto-canary/all-contributors@10.24.2--canary.1936.23773.0
yarn add @auto-canary/brew@10.24.2--canary.1936.23773.0
yarn add @auto-canary/chrome@10.24.2--canary.1936.23773.0
yarn add @auto-canary/cocoapods@10.24.2--canary.1936.23773.0
yarn add @auto-canary/conventional-commits@10.24.2--canary.1936.23773.0
yarn add @auto-canary/crates@10.24.2--canary.1936.23773.0
yarn add @auto-canary/docker@10.24.2--canary.1936.23773.0
yarn add @auto-canary/exec@10.24.2--canary.1936.23773.0
yarn add @auto-canary/first-time-contributor@10.24.2--canary.1936.23773.0
yarn add @auto-canary/gem@10.24.2--canary.1936.23773.0
yarn add @auto-canary/gh-pages@10.24.2--canary.1936.23773.0
yarn add @auto-canary/git-tag@10.24.2--canary.1936.23773.0
yarn add @auto-canary/gradle@10.24.2--canary.1936.23773.0
yarn add @auto-canary/jira@10.24.2--canary.1936.23773.0
yarn add @auto-canary/magic-zero@10.24.2--canary.1936.23773.0
yarn add @auto-canary/maven@10.24.2--canary.1936.23773.0
yarn add @auto-canary/microsoft-teams@10.24.2--canary.1936.23773.0
yarn add @auto-canary/npm@10.24.2--canary.1936.23773.0
yarn add @auto-canary/omit-commits@10.24.2--canary.1936.23773.0
yarn add @auto-canary/omit-release-notes@10.24.2--canary.1936.23773.0
yarn add @auto-canary/pr-body-labels@10.24.2--canary.1936.23773.0
yarn add @auto-canary/released@10.24.2--canary.1936.23773.0
yarn add @auto-canary/s3@10.24.2--canary.1936.23773.0
yarn add @auto-canary/slack@10.24.2--canary.1936.23773.0
yarn add @auto-canary/twitter@10.24.2--canary.1936.23773.0
yarn add @auto-canary/upload-assets@10.24.2--canary.1936.23773.0
yarn add @auto-canary/vscode@10.24.2--canary.1936.23773.0

@adierkens adierkens added the patch Increment the patch version when merged label Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #1936 (8f3197c) into main (f4f4a86) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1936   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files          65       65           
  Lines        5258     5258           
  Branches     1230     1230           
=======================================
  Hits         4218     4218           
  Misses        693      693           
  Partials      347      347           
Impacted Files Coverage Δ
plugins/npm/src/index.ts 72.98% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d0b6c...8f3197c. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit bfcaee5 into main Apr 9, 2021
@hipstersmoothie hipstersmoothie deleted the remove-lerna-yarn-dep branch April 9, 2021 03:57
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.24.3 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Apr 9, 2021
@zephraph zephraph mentioned this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPM Plugin with lerna requires yarn installed globally
3 participants