Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: import INpmConfig from npm package, not from core #1942

Merged
merged 1 commit into from Apr 15, 2021

Conversation

hasparus
Copy link
Contributor

@hasparus hasparus commented Apr 15, 2021

Hey 馃憢 Firstly, thank you so much for Auto! It already simplifies maintaining Theme UI, and I'm not even using its full capabilities (I made a typo in config file name, don't ask :P). Really good work here!

What Changed

Updated example auto.config.ts to properly import npm plugin options.

Why

INpmConfig is not exported from @auto-it/core

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

BTW, I also can't import AutoRc from auto, and had to grab it from @auto-it/core instead, but it might be just my installation.

image

@adierkens adierkens added the documentation Changes only affect the documentation label Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #1942 (d673709) into main (dfad2b2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1942   +/-   ##
=======================================
  Coverage   80.27%   80.27%           
=======================================
  Files          65       65           
  Lines        5294     5294           
  Branches     1234     1234           
=======================================
  Hits         4250     4250           
  Misses        694      694           
  Partials      350      350           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4eba2e2...d673709. Read the comment docs.

@hipstersmoothie
Copy link
Collaborator

Thanks! If you want to export the RC type from the cli feel free to make another PR!

@hipstersmoothie hipstersmoothie merged commit b3056ad into intuit:main Apr 15, 2021
@adierkens
Copy link
Collaborator

馃殌 PR was released in v10.25.1 馃殌

@adierkens adierkens added the released This issue/pull request has been released. label Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants