Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canary shouldn't make changes on dry run #1969

Merged
merged 1 commit into from Apr 28, 2021

Conversation

laughedelic
Copy link
Contributor

@laughedelic laughedelic commented Apr 28, 2021

What Changed

Make more use of dry-run option in the code of the canary action.

Why

When running

auto shipit --dry-run --quiet

on a PR, it creates the comment 📦 Published PR as canary version: .... A workaround is to add --message false, but it shouldn't create any comments claiming that things are published when it's just a dry-run (to get the version value, btw).

I also noticed when running

auto canary --dry-run --quiet

locally, it resets my unstaged Git changes 🤯 This is a destructive bug.

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@adierkens adierkens added the patch Increment the patch version when merged label Apr 28, 2021
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@3c51664). Click here to learn what that means.
The diff coverage is 40.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1969   +/-   ##
=======================================
  Coverage        ?   80.24%           
=======================================
  Files           ?       65           
  Lines           ?     5296           
  Branches        ?     1236           
=======================================
  Hits            ?     4250           
  Misses          ?      694           
  Partials        ?      352           
Impacted Files Coverage Δ
packages/core/src/auto.ts 77.72% <40.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c51664...e562e2c. Read the comment docs.

@laughedelic laughedelic marked this pull request as ready for review April 28, 2021 01:23
@hipstersmoothie hipstersmoothie merged commit 6fad656 into intuit:main Apr 28, 2021
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.25.2 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants