canary shouldn't make changes on dry run #1969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Make more use of
dry-run
option in the code of the canary action.Why
When running
on a PR, it creates the comment
📦 Published PR as canary version: ...
. A workaround is to add--message false
, but it shouldn't create any comments claiming that things are published when it's just a dry-run (to get the version value, btw).I also noticed when running
locally, it resets my unstaged Git changes 🤯 This is a destructive bug.
Todo:
Change Type
Indicate the type of change your pull request is:
documentation
patch
minor
major