Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rearrange to allow dryrun to leverage prefixed tag #1976

Merged
merged 2 commits into from May 8, 2021

Conversation

spentacular
Copy link
Collaborator

What Changed

Rearrange the order in git-tag version hook so that !newTag is checked first, allowing dryRun & quiet to received the potential prefixed version.

Why

Ensures the dryRun and normal flows both output the same version string.

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@adierkens adierkens added the patch Increment the patch version when merged label May 5, 2021
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #1976 (dc5bf05) into main (66b34a1) will not change coverage.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1976   +/-   ##
=======================================
  Coverage   80.18%   80.18%           
=======================================
  Files          65       65           
  Lines        5300     5300           
  Branches     1237     1237           
=======================================
  Hits         4250     4250           
  Misses        697      697           
  Partials      353      353           
Impacted Files Coverage Δ
plugins/git-tag/src/index.ts 78.43% <20.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 987c976...dc5bf05. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit a7cfda2 into intuit:main May 8, 2021
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.27.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants