Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: push multiple podspecs #1982

Merged
merged 3 commits into from May 19, 2021
Merged

Conversation

hborawski
Copy link
Collaborator

@hborawski hborawski commented May 18, 2021

What Changed

podspecPath can now be an array of paths to podspecs that will all get pushed and versioned the same

Why

Feature request from a user, since it's git backed we need to keep them all the same version, using the plugin multiple times would cause duplicate tags in git

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.1982.24234.gz
auto-macos--canary.1982.24234.gz
auto-win.exe--canary.1982.24234.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.28.0--canary.1982.24234.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.28.0--canary.1982.24234.0
npm install @auto-canary/auto@10.28.0--canary.1982.24234.0
npm install @auto-canary/core@10.28.0--canary.1982.24234.0
npm install @auto-canary/package-json-utils@10.28.0--canary.1982.24234.0
npm install @auto-canary/all-contributors@10.28.0--canary.1982.24234.0
npm install @auto-canary/brew@10.28.0--canary.1982.24234.0
npm install @auto-canary/chrome@10.28.0--canary.1982.24234.0
npm install @auto-canary/cocoapods@10.28.0--canary.1982.24234.0
npm install @auto-canary/conventional-commits@10.28.0--canary.1982.24234.0
npm install @auto-canary/crates@10.28.0--canary.1982.24234.0
npm install @auto-canary/docker@10.28.0--canary.1982.24234.0
npm install @auto-canary/exec@10.28.0--canary.1982.24234.0
npm install @auto-canary/first-time-contributor@10.28.0--canary.1982.24234.0
npm install @auto-canary/gem@10.28.0--canary.1982.24234.0
npm install @auto-canary/gh-pages@10.28.0--canary.1982.24234.0
npm install @auto-canary/git-tag@10.28.0--canary.1982.24234.0
npm install @auto-canary/gradle@10.28.0--canary.1982.24234.0
npm install @auto-canary/jira@10.28.0--canary.1982.24234.0
npm install @auto-canary/magic-zero@10.28.0--canary.1982.24234.0
npm install @auto-canary/maven@10.28.0--canary.1982.24234.0
npm install @auto-canary/microsoft-teams@10.28.0--canary.1982.24234.0
npm install @auto-canary/npm@10.28.0--canary.1982.24234.0
npm install @auto-canary/omit-commits@10.28.0--canary.1982.24234.0
npm install @auto-canary/omit-release-notes@10.28.0--canary.1982.24234.0
npm install @auto-canary/pr-body-labels@10.28.0--canary.1982.24234.0
npm install @auto-canary/released@10.28.0--canary.1982.24234.0
npm install @auto-canary/s3@10.28.0--canary.1982.24234.0
npm install @auto-canary/sbt@10.28.0--canary.1982.24234.0
npm install @auto-canary/slack@10.28.0--canary.1982.24234.0
npm install @auto-canary/twitter@10.28.0--canary.1982.24234.0
npm install @auto-canary/upload-assets@10.28.0--canary.1982.24234.0
npm install @auto-canary/vscode@10.28.0--canary.1982.24234.0
# or 
yarn add @auto-canary/bot-list@10.28.0--canary.1982.24234.0
yarn add @auto-canary/auto@10.28.0--canary.1982.24234.0
yarn add @auto-canary/core@10.28.0--canary.1982.24234.0
yarn add @auto-canary/package-json-utils@10.28.0--canary.1982.24234.0
yarn add @auto-canary/all-contributors@10.28.0--canary.1982.24234.0
yarn add @auto-canary/brew@10.28.0--canary.1982.24234.0
yarn add @auto-canary/chrome@10.28.0--canary.1982.24234.0
yarn add @auto-canary/cocoapods@10.28.0--canary.1982.24234.0
yarn add @auto-canary/conventional-commits@10.28.0--canary.1982.24234.0
yarn add @auto-canary/crates@10.28.0--canary.1982.24234.0
yarn add @auto-canary/docker@10.28.0--canary.1982.24234.0
yarn add @auto-canary/exec@10.28.0--canary.1982.24234.0
yarn add @auto-canary/first-time-contributor@10.28.0--canary.1982.24234.0
yarn add @auto-canary/gem@10.28.0--canary.1982.24234.0
yarn add @auto-canary/gh-pages@10.28.0--canary.1982.24234.0
yarn add @auto-canary/git-tag@10.28.0--canary.1982.24234.0
yarn add @auto-canary/gradle@10.28.0--canary.1982.24234.0
yarn add @auto-canary/jira@10.28.0--canary.1982.24234.0
yarn add @auto-canary/magic-zero@10.28.0--canary.1982.24234.0
yarn add @auto-canary/maven@10.28.0--canary.1982.24234.0
yarn add @auto-canary/microsoft-teams@10.28.0--canary.1982.24234.0
yarn add @auto-canary/npm@10.28.0--canary.1982.24234.0
yarn add @auto-canary/omit-commits@10.28.0--canary.1982.24234.0
yarn add @auto-canary/omit-release-notes@10.28.0--canary.1982.24234.0
yarn add @auto-canary/pr-body-labels@10.28.0--canary.1982.24234.0
yarn add @auto-canary/released@10.28.0--canary.1982.24234.0
yarn add @auto-canary/s3@10.28.0--canary.1982.24234.0
yarn add @auto-canary/sbt@10.28.0--canary.1982.24234.0
yarn add @auto-canary/slack@10.28.0--canary.1982.24234.0
yarn add @auto-canary/twitter@10.28.0--canary.1982.24234.0
yarn add @auto-canary/upload-assets@10.28.0--canary.1982.24234.0
yarn add @auto-canary/vscode@10.28.0--canary.1982.24234.0

@adierkens adierkens added the minor Increment the minor version when merged label May 18, 2021
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #1982 (5dfa5a7) into main (5d33773) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1982      +/-   ##
==========================================
+ Coverage   80.17%   80.24%   +0.06%     
==========================================
  Files          66       66              
  Lines        5386     5405      +19     
  Branches     1252     1253       +1     
==========================================
+ Hits         4318     4337      +19     
+ Misses        708      707       -1     
- Partials      360      361       +1     
Impacted Files Coverage Δ
plugins/cocoapods/src/index.ts 88.95% <100.00%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd6b041...5dfa5a7. Read the comment docs.

@hborawski
Copy link
Collaborator Author

canary has been tested on a project internally and works

@adierkens adierkens merged commit b8697c8 into intuit:main May 19, 2021
@hborawski hborawski deleted the cocoapods-multi-specs branch May 19, 2021 18:04
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.28.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants