Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #1997 #2010

Merged
merged 1 commit into from Jun 8, 2021
Merged

Revert #1997 #2010

merged 1 commit into from Jun 8, 2021

Conversation

10hendersonm
Copy link
Contributor

@10hendersonm 10hendersonm commented Jun 7, 2021

This reverts commit 1e83684, reversing changes made to 1f27b91.

What Changed

Reverts #1997

Why

closes #2007

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

Sorry bout this, everybody

🐤 Download canary assets:

auto-linux--canary.2010.24434.gz
auto-macos--canary.2010.24434.gz
auto-win.exe--canary.2010.24434.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.29.3--canary.2010.24434.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.29.3--canary.2010.24434.0
npm install @auto-canary/auto@10.29.3--canary.2010.24434.0
npm install @auto-canary/core@10.29.3--canary.2010.24434.0
npm install @auto-canary/package-json-utils@10.29.3--canary.2010.24434.0
npm install @auto-canary/all-contributors@10.29.3--canary.2010.24434.0
npm install @auto-canary/brew@10.29.3--canary.2010.24434.0
npm install @auto-canary/chrome@10.29.3--canary.2010.24434.0
npm install @auto-canary/cocoapods@10.29.3--canary.2010.24434.0
npm install @auto-canary/conventional-commits@10.29.3--canary.2010.24434.0
npm install @auto-canary/crates@10.29.3--canary.2010.24434.0
npm install @auto-canary/docker@10.29.3--canary.2010.24434.0
npm install @auto-canary/exec@10.29.3--canary.2010.24434.0
npm install @auto-canary/first-time-contributor@10.29.3--canary.2010.24434.0
npm install @auto-canary/gem@10.29.3--canary.2010.24434.0
npm install @auto-canary/gh-pages@10.29.3--canary.2010.24434.0
npm install @auto-canary/git-tag@10.29.3--canary.2010.24434.0
npm install @auto-canary/gradle@10.29.3--canary.2010.24434.0
npm install @auto-canary/jira@10.29.3--canary.2010.24434.0
npm install @auto-canary/magic-zero@10.29.3--canary.2010.24434.0
npm install @auto-canary/maven@10.29.3--canary.2010.24434.0
npm install @auto-canary/microsoft-teams@10.29.3--canary.2010.24434.0
npm install @auto-canary/npm@10.29.3--canary.2010.24434.0
npm install @auto-canary/omit-commits@10.29.3--canary.2010.24434.0
npm install @auto-canary/omit-release-notes@10.29.3--canary.2010.24434.0
npm install @auto-canary/pr-body-labels@10.29.3--canary.2010.24434.0
npm install @auto-canary/released@10.29.3--canary.2010.24434.0
npm install @auto-canary/s3@10.29.3--canary.2010.24434.0
npm install @auto-canary/sbt@10.29.3--canary.2010.24434.0
npm install @auto-canary/slack@10.29.3--canary.2010.24434.0
npm install @auto-canary/twitter@10.29.3--canary.2010.24434.0
npm install @auto-canary/upload-assets@10.29.3--canary.2010.24434.0
npm install @auto-canary/vscode@10.29.3--canary.2010.24434.0
# or 
yarn add @auto-canary/bot-list@10.29.3--canary.2010.24434.0
yarn add @auto-canary/auto@10.29.3--canary.2010.24434.0
yarn add @auto-canary/core@10.29.3--canary.2010.24434.0
yarn add @auto-canary/package-json-utils@10.29.3--canary.2010.24434.0
yarn add @auto-canary/all-contributors@10.29.3--canary.2010.24434.0
yarn add @auto-canary/brew@10.29.3--canary.2010.24434.0
yarn add @auto-canary/chrome@10.29.3--canary.2010.24434.0
yarn add @auto-canary/cocoapods@10.29.3--canary.2010.24434.0
yarn add @auto-canary/conventional-commits@10.29.3--canary.2010.24434.0
yarn add @auto-canary/crates@10.29.3--canary.2010.24434.0
yarn add @auto-canary/docker@10.29.3--canary.2010.24434.0
yarn add @auto-canary/exec@10.29.3--canary.2010.24434.0
yarn add @auto-canary/first-time-contributor@10.29.3--canary.2010.24434.0
yarn add @auto-canary/gem@10.29.3--canary.2010.24434.0
yarn add @auto-canary/gh-pages@10.29.3--canary.2010.24434.0
yarn add @auto-canary/git-tag@10.29.3--canary.2010.24434.0
yarn add @auto-canary/gradle@10.29.3--canary.2010.24434.0
yarn add @auto-canary/jira@10.29.3--canary.2010.24434.0
yarn add @auto-canary/magic-zero@10.29.3--canary.2010.24434.0
yarn add @auto-canary/maven@10.29.3--canary.2010.24434.0
yarn add @auto-canary/microsoft-teams@10.29.3--canary.2010.24434.0
yarn add @auto-canary/npm@10.29.3--canary.2010.24434.0
yarn add @auto-canary/omit-commits@10.29.3--canary.2010.24434.0
yarn add @auto-canary/omit-release-notes@10.29.3--canary.2010.24434.0
yarn add @auto-canary/pr-body-labels@10.29.3--canary.2010.24434.0
yarn add @auto-canary/released@10.29.3--canary.2010.24434.0
yarn add @auto-canary/s3@10.29.3--canary.2010.24434.0
yarn add @auto-canary/sbt@10.29.3--canary.2010.24434.0
yarn add @auto-canary/slack@10.29.3--canary.2010.24434.0
yarn add @auto-canary/twitter@10.29.3--canary.2010.24434.0
yarn add @auto-canary/upload-assets@10.29.3--canary.2010.24434.0
yarn add @auto-canary/vscode@10.29.3--canary.2010.24434.0

…e_dash"

This reverts commit 1e83684, reversing
changes made to 1f27b91.
@adierkens adierkens added the patch Increment the patch version when merged label Jun 7, 2021
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #2010 (85e8ecd) into main (6051e9e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2010      +/-   ##
==========================================
- Coverage   80.24%   80.23%   -0.01%     
==========================================
  Files          66       66              
  Lines        5395     5394       -1     
  Branches     1249     1249              
==========================================
- Hits         4329     4328       -1     
  Misses        706      706              
  Partials      360      360              
Impacted Files Coverage Δ
plugins/npm/src/index.ts 72.98% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6051e9e...85e8ecd. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 3f1752f into intuit:main Jun 8, 2021
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.29.3 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unapproved PR builds now override beta builds in Semver ranges
3 participants