Support --use-version argument with shipit #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2075 +/- ##
==========================================
- Coverage 80.24% 80.19% -0.06%
==========================================
Files 66 66
Lines 5397 5403 +6
Branches 1251 1254 +3
==========================================
+ Hits 4331 4333 +2
- Misses 706 709 +3
- Partials 360 361 +1
Continue to review full report at Codecov.
|
hipstersmoothie
requested changes
Sep 15, 2021
|
@hipstersmoothie I have addressed your PR comments, let me know if you need anything else! |
hipstersmoothie
added
minor
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Updated the
auto shipitcommand to enable setting the--use-versionflag. (Currently only supported for the npm plugin)Additional Changes:
.editorconfigto force consistency across dev environmentsgetLatestReleasedTagWithPatternto provide better support for GitHub "release" version based on a provided pattern.Why
There are use cases where we want to specify the version to release through
shipit. In particular, when maintaining multiple old version branches, version calculations are computed incorrectly. In order to support complex semantic release workflows through npm, this is a temporary solution until the root cause can be determined (i.e.oldRelease()) .Todo:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor