fix(plugin/microsoft-teams): incorrect markdown rendering #2080
Conversation
| expect(fetchSpy.mock.calls[0][1].body).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| test("should add more indents to nested lists", async () => { |
There was a problem hiding this comment.
Note: I removed this test because the code, both before and after my changes, did (/does) not add more indents to nested lists.
I think this might have been originaly copy/pasted from the slack plugin tests.
| expect(fetchSpy.mock.calls[0][1].body).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| test("should add more indents to nested lists - 2 spaces", async () => { |
There was a problem hiding this comment.
| @@ -276,28 +236,13 @@ describe("createPost", () => { | |||
| expect(fetchSpy.mock.calls[0][1].body).toMatchSnapshot(); | |||
| }); | |||
|
|
|||
| test("should remove markdown code types from block", async () => { | |||
There was a problem hiding this comment.
| logger: dummyLog(), | ||
| } as any; | ||
|
|
||
| describe("postToMicrosoftTeams", () => { |
There was a problem hiding this comment.
It looks to me like those 2 tests are identical to the ones in index.test.ts:
- "should call Microsoft Office Teams api with minimal config"
- "should call Microsoft Office Teams api through http proxy"
|
ping @reintroducing @vincentbriglia @hipstersmoothie Let me know is you see anything wrong, thank you!! :) |
Codecov Report
@@ Coverage Diff @@
## main #2080 +/- ##
==========================================
- Coverage 80.19% 80.18% -0.01%
==========================================
Files 66 66
Lines 5403 5401 -2
Branches 1254 1254
==========================================
- Hits 4333 4331 -2
Misses 709 709
Partials 361 361
Continue to review full report at Codecov.
|
|
@jakobe Thanks! Is the coverage check (codecov/project) blocking this PR from getting merged? |
|
ping @jakobe Can we get this merged? Thanks! |
Hey @mathieubergeron sorry for the waaaaay late reply, I have a mail filter setup for Github mails otherwise I just drown 😅 , so haven't paid attention to this 🙈 I'm not the maintainer of this project, just chimed in with my findings and a PR approval to state that it looks good IMHO 👍🏻 ping @hipstersmoothie 😄 |
@hipstersmoothie Any plans for merging this? 🙏🏻 |
|
🚀 PR was released in |
|
Thx @hipstersmoothie 🙏🏻 |
What Changed
Changes in this PR are related to the microsoft-teams plugin, and the following issue: #2020.
I removed the part that escaped characters using the
jsesclibrary.Note that I also removed some of the unit tests, which was either duplicated or not useful. I will leave comments about those in the PR.
Why
It seems that we don't know why
jsescwas used in the first place, but it is breaking the markdown rendering.Before:
After:
Todo:
Add testsChange Type
Indicate the type of change your pull request is:
documentationpatchminormajor