Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use strict check so SEMVER.noVersion can add skip-release #2086

Merged
merged 2 commits into from Sep 30, 2021

Conversation

hborawski
Copy link
Collaborator

@hborawski hborawski commented Sep 30, 2021

What Changed

instead of !bump which catches SEMVER.noVersion, check for undefined or null

map noVersion to skip

remove memoize from getLabels, otherwise any labels added by plugins in pr-check don't get considered and check can fail

Why

The default release type is skip but PR wont be labelled by the plugin if that's the calculation, so the pr-check still shows an error state in github

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.2086.24847.gz
auto-macos--canary.2086.24847.gz
auto-win.exe--canary.2086.24847.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.32.1--canary.2086.24847.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.32.1--canary.2086.24847.0
npm install @auto-canary/auto@10.32.1--canary.2086.24847.0
npm install @auto-canary/core@10.32.1--canary.2086.24847.0
npm install @auto-canary/package-json-utils@10.32.1--canary.2086.24847.0
npm install @auto-canary/all-contributors@10.32.1--canary.2086.24847.0
npm install @auto-canary/brew@10.32.1--canary.2086.24847.0
npm install @auto-canary/chrome@10.32.1--canary.2086.24847.0
npm install @auto-canary/cocoapods@10.32.1--canary.2086.24847.0
npm install @auto-canary/conventional-commits@10.32.1--canary.2086.24847.0
npm install @auto-canary/crates@10.32.1--canary.2086.24847.0
npm install @auto-canary/docker@10.32.1--canary.2086.24847.0
npm install @auto-canary/exec@10.32.1--canary.2086.24847.0
npm install @auto-canary/first-time-contributor@10.32.1--canary.2086.24847.0
npm install @auto-canary/gem@10.32.1--canary.2086.24847.0
npm install @auto-canary/gh-pages@10.32.1--canary.2086.24847.0
npm install @auto-canary/git-tag@10.32.1--canary.2086.24847.0
npm install @auto-canary/gradle@10.32.1--canary.2086.24847.0
npm install @auto-canary/jira@10.32.1--canary.2086.24847.0
npm install @auto-canary/magic-zero@10.32.1--canary.2086.24847.0
npm install @auto-canary/maven@10.32.1--canary.2086.24847.0
npm install @auto-canary/microsoft-teams@10.32.1--canary.2086.24847.0
npm install @auto-canary/npm@10.32.1--canary.2086.24847.0
npm install @auto-canary/omit-commits@10.32.1--canary.2086.24847.0
npm install @auto-canary/omit-release-notes@10.32.1--canary.2086.24847.0
npm install @auto-canary/pr-body-labels@10.32.1--canary.2086.24847.0
npm install @auto-canary/released@10.32.1--canary.2086.24847.0
npm install @auto-canary/s3@10.32.1--canary.2086.24847.0
npm install @auto-canary/sbt@10.32.1--canary.2086.24847.0
npm install @auto-canary/slack@10.32.1--canary.2086.24847.0
npm install @auto-canary/twitter@10.32.1--canary.2086.24847.0
npm install @auto-canary/upload-assets@10.32.1--canary.2086.24847.0
npm install @auto-canary/vscode@10.32.1--canary.2086.24847.0
# or 
yarn add @auto-canary/bot-list@10.32.1--canary.2086.24847.0
yarn add @auto-canary/auto@10.32.1--canary.2086.24847.0
yarn add @auto-canary/core@10.32.1--canary.2086.24847.0
yarn add @auto-canary/package-json-utils@10.32.1--canary.2086.24847.0
yarn add @auto-canary/all-contributors@10.32.1--canary.2086.24847.0
yarn add @auto-canary/brew@10.32.1--canary.2086.24847.0
yarn add @auto-canary/chrome@10.32.1--canary.2086.24847.0
yarn add @auto-canary/cocoapods@10.32.1--canary.2086.24847.0
yarn add @auto-canary/conventional-commits@10.32.1--canary.2086.24847.0
yarn add @auto-canary/crates@10.32.1--canary.2086.24847.0
yarn add @auto-canary/docker@10.32.1--canary.2086.24847.0
yarn add @auto-canary/exec@10.32.1--canary.2086.24847.0
yarn add @auto-canary/first-time-contributor@10.32.1--canary.2086.24847.0
yarn add @auto-canary/gem@10.32.1--canary.2086.24847.0
yarn add @auto-canary/gh-pages@10.32.1--canary.2086.24847.0
yarn add @auto-canary/git-tag@10.32.1--canary.2086.24847.0
yarn add @auto-canary/gradle@10.32.1--canary.2086.24847.0
yarn add @auto-canary/jira@10.32.1--canary.2086.24847.0
yarn add @auto-canary/magic-zero@10.32.1--canary.2086.24847.0
yarn add @auto-canary/maven@10.32.1--canary.2086.24847.0
yarn add @auto-canary/microsoft-teams@10.32.1--canary.2086.24847.0
yarn add @auto-canary/npm@10.32.1--canary.2086.24847.0
yarn add @auto-canary/omit-commits@10.32.1--canary.2086.24847.0
yarn add @auto-canary/omit-release-notes@10.32.1--canary.2086.24847.0
yarn add @auto-canary/pr-body-labels@10.32.1--canary.2086.24847.0
yarn add @auto-canary/released@10.32.1--canary.2086.24847.0
yarn add @auto-canary/s3@10.32.1--canary.2086.24847.0
yarn add @auto-canary/sbt@10.32.1--canary.2086.24847.0
yarn add @auto-canary/slack@10.32.1--canary.2086.24847.0
yarn add @auto-canary/twitter@10.32.1--canary.2086.24847.0
yarn add @auto-canary/upload-assets@10.32.1--canary.2086.24847.0
yarn add @auto-canary/vscode@10.32.1--canary.2086.24847.0

@adierkens adierkens added the patch Increment the patch version when merged label Sep 30, 2021
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #2086 (f3bd5a5) into main (9f1a57d) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2086   +/-   ##
=======================================
  Coverage   80.19%   80.19%           
=======================================
  Files          66       66           
  Lines        5403     5404    +1     
  Branches     1254     1255    +1     
=======================================
+ Hits         4333     4334    +1     
  Misses        709      709           
  Partials      361      361           
Impacted Files Coverage Δ
packages/core/src/git.ts 87.53% <ø> (ø)
plugins/conventional-commits/src/index.ts 77.60% <66.66%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d79865f...f3bd5a5. Read the comment docs.

@adierkens adierkens merged commit d1b3438 into intuit:main Sep 30, 2021
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.32.1 🚀

@adierkens adierkens added released This issue/pull request has been released. hacktoberfest hacktoberfest-accepted labels Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest hacktoberfest-accepted patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants