Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript definitions #93

Open
ibox4real opened this issue Aug 6, 2020 · 8 comments
Open

Typescript definitions #93

ibox4real opened this issue Aug 6, 2020 · 8 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@ibox4real
Copy link

Any chance we would get Typescript support for the oauth-jsclient?

@abisalehalliprasan abisalehalliprasan added the enhancement New feature or request label Aug 18, 2020
@abisalehalliprasan
Copy link
Collaborator

abisalehalliprasan commented Aug 18, 2020

@ibox4real : We do not have any immediate plans at the moment to provide Typescript support, however, I can take this information to my team and see if we can prioritize and have this on the roadmap.

Meanwhile, there is a typescript branch If you'd be interested to take a look at.

@prateekkathal
Copy link

@ibox4real You can use the index.d.ts file in the root folder of above mentioned branch in your src/@types/intuit-oauth folder by declaring a module with the name 'intuit-oauth'.

Something like this

declare module 'intuit-oauth' {
  // ... index.d.ts code
  // replace all 'declare' keywords with 'export'
}

Just to be clear, this is a temporary solution till the time types are added to the master/release branch..

@MitchWeber
Copy link

Any updates when the types will be released?

@gmicek
Copy link

gmicek commented Apr 23, 2021

hey @abisalehalliprasan , would you all please go ahead and merge the typescript branch and support into master and publish? You can even mark it experimental or something. At this time, I think a lot of the users including myself are either just copying the types into our own type directories or writing our own types.

I think it will be more helpful to merge to master now and note if they may not be complete than to keep them hidden on a separate branch that most users aren't aware of. Thanks!

@abisalehalliprasan
Copy link
Collaborator

@gmicek : There a few things which need to be tested before we release the typescript version.

We will prioritize a release very soon. Thanks for the understanding everyone. Will keep this thread posted with updates.

@digibake
Copy link

digibake commented Dec 3, 2021

I noticed there's a new pull request which adds typescript definitions, does this mean there'll be a new release soon? It would be really a useful addition.

@anilkumarbp
Copy link

@digibake : Sorry for the delay. Let me be clear that, we are not working towards the migration of the entire library to TS. I'm not a 100% familiar with this so any feedback would be great.

Do you think publishing the typings alone would help us resolve here?

@GuiSim
Copy link

GuiSim commented Apr 28, 2022

Can we get an update here? It's been years since this was "nearly merged" #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

9 participants